Remove GHSA-fc9h-whq2-v747 now that a fix is available #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, this was added because a fix wasn't yet available and we reviewed the issue and didn't believe it would present issues. The code paths that rely on this transitive dependency are almost always dead code paths for us. In the cases where it wouldn't have been it would have produced false negative verifications. While this would have been annoying to encounter it would still fail safely. Now that a fix is available, we can bump it to fix it properly.
diracdeltas
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#41714
Originally, this was added because a fix wasn't yet available and we reviewed the issue and didn't believe it would present issues. The code paths that rely on this transitive dependency are almost always dead code paths for us. In the cases where it wouldn't have been it would have produced false negative verifications. While this would have been annoying to encounter it would still fail safely. Now that a fix is available, we can bump it to fix it properly.