Tweak to UI #121
Open
Tweak to UI #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of copy-pasting the same code 3x. Additionally also update after saving. This way the text gets nicely formatted and reflects what actually in the DB.
|
Hi I understand what this change is trying to do but I can't reproduce it locally. Can you please provide a video or steps to reproduce what bug this solves? |
|
Hi, The app correctly interprets 098 as 98 but this is not apparent to the user. a.mp4With the tweak the UI now shows 98, which is what is actually saved in the DB. b.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
love the app. I have been playing around with it in the last week and am providing here a small tweak to the UI for adding a new set.
Change: After pushing "save", the text input fields get nicely formatted with toString() so they are consistent with the values read from the DB.
Also put the code for setting the text fields in its own method.
Best regards,
David