Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cleanRows function to recognize also negative numbers #12

Closed
wants to merge 1 commit into from
Closed

Update cleanRows function to recognize also negative numbers #12

wants to merge 1 commit into from

Conversation

MiliusCZ
Copy link

Modified cleanRows function to recongize also negative numbers

@MiliusCZ
Update fetch-sheet.js
6480374 
Modified cleanRows function to recongize also negative numbers
@MiliusCZ
Copy link
Author

This PR resolves the issue #11

@MiliusCZ MiliusCZ changed the title Update fetch-sheet.js Update cleanRows function to recognize also negative numbers Jul 21, 2018
@MartinNuc
Copy link
Contributor

MartinNuc commented Aug 31, 2018 •
edited
Loading

This part is also mentioned in README.md. Maybe it should be updated too?

@drewatk
Copy link
Collaborator

drewatk commented Apr 9, 2019

Closing this issue for now as it conflicts with changes in #19. If you'd like to update with the new logic, please do and I'll reopen!
If not I'll get to this as work for the next release, and will track your issue (#11) to be included in that release.

@drewatk drewatk closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiliusCZ @MartinNuc @drewatk