valid html: nomodule flag, not type="nomodule"

brandcom · Mar 15, 2022 · a2298e5 · a2298e5
1 parent 74478ab
commit a2298e5
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/View/Helper/ViteScriptsHelper.php b/src/View/Helper/ViteScriptsHelper.php
@@ -73,10 +73,15 @@ public function body(): string
         $tags = [];
         foreach ($this->manifest->getJsFiles() as $path) {
 
-            $type = Strings::contains($path, "legacy") ? "nomodule" : "module";
-            $tags[] = $this->Html->script($path, [
-                'type' => $type,
-            ]);
+            $options = [];
+
+            if (Strings::contains($path, "legacy")) {
+                $options['nomodule'] = 'nomodule';
+            } else {
+                $options['type'] = 'module';
+            }
+
+            $tags[] = $this->Html->script($path, $options);
         }
 
         return implode("\n", $tags);