[v7 Beta] Create DropInLauncher #468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e0658c3.
jaxdesmarais
reviewed
Apr 4, 2024
| @@ -152,7 +187,8 @@ public void launchDropIn(View v) { | |||
| dropInRequest.setThreeDSecureRequest(demoThreeDSecureRequest()); | |||
| } | |||
|
|
|||
| dropInClient.launchDropIn(dropInRequest); | |||
| // TODO: make auth string a required DropInRequest constructor parameter | |||
| dropInLauncher.launchDropIn(authString, dropInRequest); | |||
There was a problem hiding this comment.
This reads a little odd to me since it's like the inverse of one another, not sure if something like this would make it feel less awward:
Suggested change
| dropInLauncher.launchDropIn(authString, dropInRequest); | |
| dropInLauncher.start(authString, dropInRequest); |
There was a problem hiding this comment.
Yeah def that's a good call. It aligns nicely with our SDKs as a whole. I'll do this in a separate commit to make sure all occurrences are renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
DropInClientwithDropInLauncherDropInLauncherCallbackto receive Activity resultfetchMostRecentPaymentMethod()toRecentPaymentMethodsClientChecklist
Authors