added project btn disabling feature #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
reviewed
Dec 13, 2022
Co-authored-by: Jan Romann <[email protected]>
| @@ -52,6 +52,7 @@ export default function AddProjectModal() { | |||
| className='btn btn-primary' | |||
| data-bs-toggle='modal' | |||
| data-bs-target='#addProjectModal' | |||
| disabled={data.clients.length === 0} | |||
There was a problem hiding this comment.
Suggested change
| disabled={data.clients.length === 0} | |
| disabled={!data.clients.length} |
SpooRe91
approved these changes
Aug 5, 2023
SpooRe91
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After learning graphQL via your video, I recognized that it will be better to add a certain simple one-line feature:
It is better to prevent adding a project while there is not any client registered. It will be not necessary while we had a feature of projects assignment but not included in the architecture you designed.
P. S: I'm learning to use and contribute to open-source projects lol.