Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for code coverage with blanket.js #107

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

selvakn
Copy link

@selvakn selvakn commented Mar 24, 2013

With this, code coverage can be measured with blanket.js.

In a file called spec_cover.js under spec/javascripts, include the source files (with sprockets) which needs to be measured for code coverage.

Simple contents of a spec_cover.js
//= require application

Thoughts?

@selvakn
Copy link
Author

selvakn commented Mar 30, 2013

Added readme and samples for code coverage with blanket.js

Please let me know if I can do anything for pulling this in.

@jejacks0n
Copy link
Collaborator

I like it, but I'm not likely to merge it.

So, I specifically started contributing to Jasminerice because it's a great little javascript testing solution for rails -- and I want to keep it simple and small. I've written a more advanced solution (Teabag) that does include coverage, and many more features.

That, the fact that we can't release new versions of the Jasminerice gem, and that with guard-jasmine/jasminerice you can already get coverage reports means that this functionality can be achieved without putting it into Jasminerice directly.

I'm basing this decision on what I think Jasminerice is really good at, and not based on the quality of this pull request. It's much appreciated, just doesn't fit with where I think Jasminerice fits in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants