Implement more efficient batch rule evaluator #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scudette
pushed a commit
to Velocidex/sigma-go
that referenced
this pull request
Oct 25, 2024
* mvp * Fuzz, move to new, correct library * Use same technique for regexes * cleanup * dedupe matching logic
scudette
pushed a commit
to Velocidex/sigma-go
that referenced
this pull request
Oct 25, 2024
* mvp * Fuzz, move to new, correct library * Use same technique for regexes * cleanup * dedupe matching logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new evaluator which processes a bundle of rules in one go. By doing so it can make use of more efficient string matching algorithms (namely Aho-Corasik) which are significantly faster than
strings.ContainsBenchmarking this on phish.report data, this new bundle evaluator is >50x faster than running individual rules