Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schema for attributes #2

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add schema for attributes #2

wants to merge 1 commit into from

Conversation

falko
Copy link
Member

@falko falko commented Dec 7, 2022

Revert the schema deletion of #1 and instead defines a schema for the new attributes

@falko falko marked this pull request as draft December 7, 2022 16:31
@SimonRinguette
Copy link
Contributor

I've made your suggested changes in #3.

Please have a look and merge if this was your intention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falko @SimonRinguette