fix: improve text prompts of empty group components #982
+27
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-965-dynlist-empty-state-f
github-actions
bot
temporarily deployed
to
demo-965-dynlist-empty-state-f
vsgoulart
requested changes
Jan 15, 2024
There was a problem hiding this comment.
@Skaiir Even though this component won't ResizeObserver + refs are no that great for performance.
Let's try to use container queries instead which allows use to avoid shipping more JS
|
|
||
| return ( | ||
| <div class="fjs-empty-component" ref={ emptyComponentRef }> | ||
| <span style={ { display: isHidden ? 'none' : 'inline' } }>Drag and drop components here.</span> |
There was a problem hiding this comment.
Let's use classes instead of inlining it
bpmn-io-tasks
bot
added
in progress
github-actions
bot
temporarily deployed
to
demo-965-dynlist-empty-state-f
|
Oooh snazzy new feature I (and GPT) wasn't aware of. |
Skaiir
force-pushed
the
965-dynlist-empty-state-fix
branch
from
df63da5 to
404a750
Compare
github-actions
bot
temporarily deployed
to
demo-965-dynlist-empty-state-f
bpmn-io-tasks
bot
added
needs review
github-actions
bot
temporarily deployed
to
demo-965-dynlist-empty-state-f
vsgoulart
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #965
@volodymyr-melnykc I made the hiding threshold 100pixels instead because it still seems to look okay, let me know how it seems to you.
@vsgoulart Opted for a mutationobserver for simplicity, since this is purely a visual thing