Use named exports across codebase #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
needs review
bpmn-io-tasks
bot
added
in progress
Skaiir
force-pushed
the
fix-form-reactivity
branch
from
704b5b7 to
293a941
Compare
Skaiir
force-pushed
the
no-default-imports
branch
from
a1286b1 to
8053454
Compare
Skaiir
force-pushed
the
no-default-imports
branch
from
8053454 to
485a9e1
Compare
bpmn-io-tasks
bot
added
needs review
vsgoulart
approved these changes
Jan 11, 2024
| export { default as useDeepCompareState } from './useDeepCompareState'; | ||
| export { default as useSingleLineTemplateEvaluation } from './useSingleLineTemplateEvaluation'; | ||
| export { default as useTemplateEvaluation } from './useTemplateEvaluation'; | ||
| export { useCondition } from './useCondition'; |
There was a problem hiding this comment.
FYI in the future we should reconsider the use of these barrel files. They are very bad for performance and makes tree-shaking harder/impossible
There was a problem hiding this comment.
Definitely worth an investigation at the very least. But it's pretty much the standard across all bpmn.io libs so we might want to discuss it with at least Nico.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #918