Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement form-js viewer debounce #959

Merged
merged 1 commit into from
Jan 2, 2024
Merged

feat: Implement form-js viewer debounce #959

merged 1 commit into from
Jan 2, 2024

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Dec 21, 2023 •
edited
Loading

Closes #958

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Dec 21, 2023
@Skaiir Skaiir changed the title wip debounce inputs for textarea, textfield and number field Dec 21, 2023
@Skaiir Skaiir force-pushed the 958-debounce-keyboard-inputs branch from 635943a to 8c58f10 Compare December 22, 2023 06:08
@Skaiir Skaiir requested a review from nikku December 22, 2023 06:12
@Skaiir Skaiir marked this pull request as ready for review December 22, 2023 06:12
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 22, 2023
@Skaiir Skaiir changed the title debounce inputs for textarea, textfield and number field Implement form-js viewer debounce Dec 22, 2023
@nikku nikku requested a review from barmac December 22, 2023 07:38
@Skaiir Skaiir changed the title Implement form-js viewer debounce feat: Implement form-js viewer debounce Dec 29, 2023
nikku
nikku approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tested it and it works.

@Skaiir Skaiir merged commit 6e23317 into develop Jan 2, 2024
13 of 15 checks passed
@Skaiir Skaiir deleted the 958-debounce-keyboard-inputs branch January 2, 2024 16:57
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@barmac barmac Awaiting requested review from barmac

Assignees

@Skaiir Skaiir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debounce input fields in form-js-viewer
2 participants
@Skaiir @nikku