Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing leftovers changes from table component #938

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: Add missing leftovers changes from table component #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/form-js-viewer/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export * from './render';
export * from './util';
export * from './features';

const schemaVersion = 13;
const schemaVersion = 14;

export {
Form,
Expand Down
4 changes: 3 additions & 1 deletion packages/form-js-viewer/src/util/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ const EXPRESSION_PROPERTIES = [
'validate.minLength',
'validate.maxLength',
'valuesExpression',
'url'
'url',
'dataSource',
'columnsExpression'
];

const TEMPLATE_PROPERTIES = [
Expand Down
2 changes: 1 addition & 1 deletion packages/form-js/test/spec/Form.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ describe('viewer exports', function() {
it('should expose schemaVersion', function() {
expect(typeof schemaVersion).to.eql('number');

expect(schemaVersion).to.eql(13);
expect(schemaVersion).to.eql(14);
});


Expand Down
1 change: 1 addition & 0 deletions packages/form-json-schema/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ This schema is currently only compatible with following [form-js](https://github
| JSON schema version | form-js schema version |
|---|---|
| >= 1.5.0 | <= 13 |
| >= 1.6.0 | <= 14 |

## License

Expand Down
6 changes: 3 additions & 3 deletions packages/form-json-schema/src/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"description": "The schema version of a form",
"type": "integer",
"minimum": 1,
"maximum": 13
"maximum": 14
},
"executionPlatform": {
"$id": "#/executionPlatform",
Expand Down Expand Up @@ -57,8 +57,8 @@
]
}
},
"required": [
"type",
"required": [
"type",
"components"
]
}
6 changes: 3 additions & 3 deletions packages/form-json-schema/test/fixtures/schemaVersion-not-supported.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
export const form = {
type: 'default',
components: [],
schemaVersion: 14
schemaVersion: 15
};

export const errors = [
{
instancePath: '/schemaVersion',
schemaPath: '#/properties/schemaVersion/maximum',
keyword: 'maximum',
params: { comparison: '<=', limit: 13 },
message: 'must be <= 13'
params: { comparison: '<=', limit: 14 },
message: 'must be <= 14'
}
];
Loading