Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5 release final check #923

Closed
wants to merge 53 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
9851b69
chore: update actions/add-to-project digest to 0be3b65
renovate[bot] Nov 2, 2023
2302eea
Merge master to develop
bpmn-io-bot Nov 2, 2023
bea90f4
Merge master to develop
bpmn-io-bot Nov 2, 2023
6690d2e
feat: add `form-json-schema` package
Oct 31, 2023
2634938
chore: link JSON schema to test fixtures
Oct 31, 2023
76f53c6
fix(schema): allow rows to be empty in form schema
Oct 31, 2023
2e00595
deps: downgrade `json-schema-ref-parser`
Nov 2, 2023
a456a03
Merge master to develop
bpmn-io-bot Nov 2, 2023
1be5640
deps: bump to [email protected] (#879)
Nov 2, 2023
fad734c
Merge branch 'master' into develop
Nov 6, 2023
7b6e6ce
chore(CI): updated snapshots [skip ci]
bpmn-io-bot Nov 6, 2023
246cd29
Merge master to develop
bpmn-io-bot Nov 6, 2023
91202c4
Merge master to develop
bpmn-io-bot Nov 6, 2023
46714d6
Merge master to develop
bpmn-io-bot Nov 7, 2023
7e9a761
chore(carbon-styles): deprecate `carbon-styles.js`
Nov 7, 2023
2961e11
feat(carbon-styles): introduce SASS stylesheet
Nov 7, 2023
6f407f4
test(e2e): add visual regression test for carbon-styles
Nov 7, 2023
4edfba2
Merge master to develop
bpmn-io-bot Nov 8, 2023
2cce46b
chore(CHANGELOG): update to v1.5.0-alpha.0
Nov 9, 2023
62825aa
deps: push lockfile changes
Nov 9, 2023
dd79ef1
chore(project): publish v1.5.0-alpha.0
Nov 9, 2023
b905265
feat(editor): introduce `container` group
Nov 9, 2023
2c55d53
chore(CI): updated snapshots [skip ci]
bpmn-io-bot Nov 9, 2023
5829117
chore: update actions/setup-node digest to ee36e8b
renovate[bot] Nov 10, 2023
5f7e8b7
chore: update actions/setup-node digest to 5ef044f
renovate[bot] Nov 14, 2023
483f8fb
Merge master to develop
vsgoulart Nov 17, 2023
648c5d1
chore(CI): updated snapshots [skip ci]
bpmn-io-bot Nov 17, 2023
6bd3f0d
test: Fix visual regression tests mistake
vsgoulart Nov 17, 2023
c35bc89
Merge master to develop
bpmn-io-bot Nov 20, 2023
81eaff5
Merge master to develop
bpmn-io-bot Nov 22, 2023
b142939
Merge master to develop
bpmn-io-bot Nov 22, 2023
59140a0
Merge master to develop
bpmn-io-bot Nov 23, 2023
bf1da8c
feat(carbon-styles): add carbon styles for iFrame
Nov 17, 2023
4e22f69
test(playground): add iFrame to test form
Nov 17, 2023
e90cf11
feat(schema): support iFrame component
Nov 17, 2023
1cac909
feat(viewer): add iFrame component
Nov 17, 2023
ec76e56
feat(editor): support editing iFrame component
Nov 17, 2023
4266c8b
test(e2e): update screenshots
Nov 20, 2023
217528b
chore: set empy sandbox attribute
Nov 20, 2023
383d001
chore(editor): display default value for height entry
Nov 21, 2023
e594457
feat(viewer): show verbose iFrame placeholder
Nov 21, 2023
89ac3fd
feat(editor): validate url
Nov 21, 2023
34ccba8
style(viewer): properly wrap placeholder content
Nov 22, 2023
c12ad18
chore(CI): updated snapshots [skip ci]
bpmn-io-bot Nov 23, 2023
ce79151
chore(viewer): export hooks
Nov 23, 2023
752e8fb
chore(CI): updated snapshots [skip ci]
bpmn-io-bot Nov 23, 2023
3f6cae3
chore: adjust palette styles
Skaiir Nov 24, 2023
106e8a7
fix: renamed checklist and radio
Skaiir Nov 24, 2023
f891c43
chore(CI): updated snapshots [skip ci]
bpmn-io-bot Nov 27, 2023
4765bb2
chore: bump [email protected] and [email protected]
Skaiir Nov 27, 2023
7d355cb
chore(CI): updated snapshots [skip ci]
bpmn-io-bot Nov 27, 2023
1cf1601
Merge master to develop
bpmn-io-bot Nov 29, 2023
284dd47
chore(CHANGELOG): v1.5
Skaiir Nov 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ADD_TO_HTO_PROJECT.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
name: Add issue to project
runs-on: ubuntu-latest
steps:
- uses: actions/add-to-project@d8e41a41861baa4c7af88a39f7692681e89f6668
- uses: actions/add-to-project@0be3b6580ae2145e72e0ada85d693ab71a5f17d6
name: Add to project
id: add-project
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/TASKLIST_CARBONISATION.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ jobs:
path: tasklist
ref: "master"
- name: Setup form-js cache
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65
uses: actions/setup-node@5ef044f9d09786428e6e895be6be17937becee3a
with:
node-version: "20"
cache: "npm"
cache-dependency-path: ./form-js/package-lock.json
- name: Setup Tasklist cache
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65
uses: actions/setup-node@5ef044f9d09786428e6e895be6be17937becee3a
with:
node-version: "20"
cache: "yarn"
Expand Down
15 changes: 15 additions & 0 deletions e2e/carbon/carbon.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
@use '@carbon/styles' as * with (
$font-path: 'https://fonts.camunda.io'
);
@use '@carbon/styles/scss/themes';
@use '@carbon/styles/scss/theme';

@import '@bpmn-io/form-js-carbon-styles/src/carbon-styles';

.cds--g10 {
@include theme.theme(themes.$g10);
}

.cds--g100 {
@include theme.theme(themes.$g100);
}
4 changes: 2 additions & 2 deletions e2e/carbon/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Forms playground</title>
<title>Carbon styles</title>
<link href="https://fonts.googleapis.com/css2?family=IBM+Plex+Sans:ital,wght@0,400;0,600;1,400&display=swap" rel="stylesheet">
<link href="https://fonts.googleapis.com/css2?family=IBM+Plex+Mono&display=swap" rel="stylesheet">
<style>
Expand All @@ -16,7 +16,7 @@
}
</style>
</head>
<body class="cds--g10">
<body class="cds--g100">
<div id="container" role="main"></div>
<script type="module" src="index.js"></script>
</body>
Expand Down
2 changes: 1 addition & 1 deletion e2e/carbon/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import '@bpmn-io/form-js/dist/assets/form-js.css';
import '@bpmn-io/form-js/dist/assets/form-js-editor.css';
import '@bpmn-io/form-js/dist/assets/form-js-playground.css';

import './theme.scss';
import './carbon.scss';

import { renderSchema } from '../renderSchema';

Expand Down
23 changes: 23 additions & 0 deletions e2e/theming/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Theming</title>
<link href="https://fonts.googleapis.com/css2?family=IBM+Plex+Sans:ital,wght@0,400;0,600;1,400&display=swap" rel="stylesheet">
<link href="https://fonts.googleapis.com/css2?family=IBM+Plex+Mono&display=swap" rel="stylesheet">
<style>
html, body, #container {
margin: 0;
padding: 0;
width: 100vw;
height: 100vh;
}
</style>
</head>
<body class="cds--g10">
<div id="container" role="main"></div>
<script type="module" src="index.js"></script>
</body>
</html>
9 changes: 9 additions & 0 deletions e2e/theming/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import '@bpmn-io/form-js/dist/assets/form-js.css';
import '@bpmn-io/form-js/dist/assets/form-js-editor.css';
import '@bpmn-io/form-js/dist/assets/form-js-playground.css';

import './theme.scss';

import { renderSchema } from '../renderSchema';

renderSchema();
13 changes: 13 additions & 0 deletions e2e/theming/theme.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
@use '@carbon/styles' as * with (
$font-path: 'https://fonts.camunda.io'
);
@use '@carbon/styles/scss/themes';
@use '@carbon/styles/scss/theme';

.cds--g10 {
@include theme.theme(themes.$g10);
}

.cds--g100 {
@include theme.theme(themes.$g100);
}
38 changes: 38 additions & 0 deletions e2e/visual/carbon-styles.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
const { expect } = require('@playwright/test');

const { test } = require('../test-fixtures');

const schema = require('./fixtures/complex.json');

test('carbon styles', async ({ page, makeAxeBuilder }) => {

// given
await page.route('/form', route => {

route.fulfill({
status: 200,
body: JSON.stringify({
data: {
schema,
component: 'viewer'
}
})
});
});

// when
await page.goto('/carbon/');

await page.waitForSelector('#container', {
state: 'visible'
});

// then
await expect(page).toHaveScreenshot();

// and then
const results = await makeAxeBuilder().analyze();

expect(results.violations).toHaveLength(0);
expect(results.passes.length).toBeGreaterThan(0);
});
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading