-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carbon Styles: Sass style sheet #842
Conversation
791bd4a
to
f62f1ed
Compare
I'd like to update the |
365b1be
to
d19947f
Compare
6c04d2f
to
55cea38
Compare
55cea38
to
3ba6e77
Compare
@vsgoulart the transformation should be done 🎉 Things to clarify
|
Some minor things are broken with the sass file (only disabled styles) I will handle these 👍 Here is the draft PR in Tasklist to replace the stylesheet: https://github.com/camunda/tasklist/pull/3749 |
3ba6e77
to
e2e6fc0
Compare
The minor issues are resolved ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it on Tasklist and everything worked fine
@@ -24,7 +24,7 @@ | |||
"./dist/assets/form-js-editor.css": "./dist/assets/form-js-editor.css", | |||
"./dist/assets/form-js-editor-base.css": "./dist/assets/form-js-editor-base.css", | |||
"./dist/assets/form-js-playground.css": "./dist/assets/form-js-playground.css", | |||
"./dist/carbon-styles": "./dist/carbon-styles.js", | |||
"./dist/assets/carbon-styles.scss": "./dist/assets/carbon-styles.scss", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we provide a CSS file too? Not sure if it's necessary, because almost everyone that uses modern Carbon would have to use SCSS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I thought about that one, but as you said, the main use case currently is Tasklist and our products anyway, so a CSS file would be obsolete. We can wait for feedback and easily add the compilation step on top.
Closes #633
carbon-styles
to ascss
filescss
filecarbon-styles.js
styled componentIt can be tested via
npm run start:carbon