fix: ensure values not in options clear #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-817-options-value-restric
packages/form-js-viewer/src/render/hooks/useRestrictedMultiSelectValues.js
Outdated
Show resolved
Hide resolved
packages/form-js-viewer/src/render/components/form-fields/parts/SimpleSelect.js
Outdated
Show resolved
Hide resolved
Comment on lines
24
to
26
| onChange({ | ||
| field, | ||
| value: values.filter(v => options.map(o => o.value).includes(v)) |
There was a problem hiding this comment.
As in the comment above having updates here might be unexpected. What would be the disadvantage of only sanitizing value here and not updating it directly? I guess it would lead to unexpected side effects as we never really clean things up?
There was a problem hiding this comment.
Yeah because then you have a mismatch between the form and the actual state. So if you have lets say, a feel expression dependent on this value, it'll still evaluate despite the form not showing that value being selected.
| @@ -0,0 +1,32 @@ | |||
| import { useEffect } from 'preact/hooks'; | |||
There was a problem hiding this comment.
I see no test added for this new behavior. Did I miss something?
Skaiir
force-pushed
the
817-options-value-restriction
branch
from
6b82707 to
e00d49d
Compare
github-actions
bot
temporarily deployed
to
demo-817-options-value-restric
github-actions
bot
temporarily deployed
to
demo-817-options-value-restric
Skaiir
force-pushed
the
817-options-value-restriction
branch
from
5e255a7 to
3017a1a
Compare
github-actions
bot
temporarily deployed
to
demo-817-options-value-restric
github-actions
bot
temporarily deployed
to
demo-817-options-value-restric
github-actions
bot
temporarily deployed
to
demo-817-options-value-restric
pinussilvestrus
approved these changes
Nov 23, 2023
|
Thanks for the follow up 👍 |
Skaiir
force-pushed
the
817-options-value-restriction
branch
from
108240d to
4c17838
Compare
github-actions
bot
temporarily deployed
to
demo-817-options-value-restric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #817