Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard support for palette entries #833

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Oct 10, 2023

This makes the palette entries actual buttons so they can be controlled via keyboard. Additionally, this adds an Enter shortcut to the entries so one can add new form fields to the bottom of the form.

Closes #536

Kapture 2023-10-10 at 14 40 20

  • This PR adds a new form-js element or visually changes an existing component.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 10, 2023
@github-actions github-actions bot temporarily deployed to demo-503-library-keyboard-supp October 10, 2023 12:14 Destroyed
@github-actions github-actions bot temporarily deployed to demo-503-library-keyboard-supp October 10, 2023 12:15 Destroyed
@pinussilvestrus pinussilvestrus force-pushed the 503-library-keyboard-support branch from f40f22e to 406d992 Compare October 10, 2023 12:24
@github-actions github-actions bot temporarily deployed to demo-503-library-keyboard-supp October 10, 2023 12:24 Destroyed
@pinussilvestrus pinussilvestrus force-pushed the 503-library-keyboard-support branch from 406d992 to 9321c46 Compare October 10, 2023 12:24
@github-actions github-actions bot temporarily deployed to demo-503-library-keyboard-supp October 10, 2023 12:25 Destroyed
@pinussilvestrus pinussilvestrus force-pushed the 503-library-keyboard-support branch from 9321c46 to b8b8733 Compare October 10, 2023 12:29
@github-actions github-actions bot temporarily deployed to demo-503-library-keyboard-supp October 10, 2023 12:29 Destroyed
@pinussilvestrus pinussilvestrus force-pushed the 503-library-keyboard-support branch from b8b8733 to 152305d Compare October 10, 2023 12:36
@github-actions github-actions bot temporarily deployed to demo-503-library-keyboard-supp October 10, 2023 12:36 Destroyed
@pinussilvestrus
Copy link
Contributor Author

The screencast is a bit misleading (focus border), seems like my screencast app is having some graphic troubles. It should work as expected in the demo.

Copy link
Contributor

@vsgoulart vsgoulart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well for me

does it maybe make sense to add support in this PR to delete items from the form when focuses and the user presses delete?

@pinussilvestrus
Copy link
Contributor Author

For the delete via keyboard we had another PR that was blocked by a core issue: #438. I have to double-check whether this affects this PR as well. I will test this one with the Desktop Modeler.

@vsgoulart
Copy link
Contributor

@pinussilvestrus the visual regression tests failed, were the changes intentional?

@pinussilvestrus
Copy link
Contributor Author

Should not, I will have a look

@pinussilvestrus
Copy link
Contributor Author

For the delete via keyboard we had another PR that was blocked by a core issue: #438. I have to double-check whether this affects this PR as well. I will test this one with the Desktop Modeler.

Works as expected 👍 I will handle the deletion shortcut separately still, as the PR is already open. Good candidate for spring cleaning as well.

Kapture 2023-10-12 at 09 18 54

@pinussilvestrus
Copy link
Contributor Author

pinussilvestrus commented Oct 12, 2023

@volodymyr-melnykc @vsgoulart The failing visual regression test is because the icons are 1px moved compared to the previous version.

I tried a few things to mitigate that, but it didn't work for all browsers reliably. I could take more time to fix this, but honestly, I'm not sure whether it's worth the time, as it doesn't look better or worse the other way around, in my opinion.

Let me know what you think; if we are fine with the 1px change, I will update the screenshots to make the tests green.

For comparison the new state (moving the diff-line from Playwright to the right). For me it even seems like the new state looks more centered.

Kapture 2023-10-12 at 11 00 32

@volodymyr-melnykc
Copy link

@pinussilvestrus It's ok for me! And yes, the new state (when the diff-line is moved to the right) looks more centered.

@pinussilvestrus pinussilvestrus force-pushed the 503-library-keyboard-support branch from 89f01b4 to 5bd4ace Compare October 12, 2023 09:48
@github-actions github-actions bot temporarily deployed to demo-503-library-keyboard-supp October 12, 2023 09:48 Destroyed
@pinussilvestrus pinussilvestrus merged commit c69357d into develop Oct 12, 2023
10 checks passed
@pinussilvestrus pinussilvestrus deleted the 503-library-keyboard-support branch October 12, 2023 09:54
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I want to browse and add components to the end of the form using my keyboard
3 participants