Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Palette module #290

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Palette module #290

merged 4 commits into from
Jul 28, 2022

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Jul 25, 2022 •
edited
Loading

Closes #280

  • Provides Palette as own module
  • Render Palette in Editor per default
  • Add Palette individually in Playground

Run playground

npm run start:playground

Run editor

npm run start:editor

image

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 25, 2022
@pinussilvestrus pinussilvestrus marked this pull request as ready for review July 26, 2022 07:27
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 26, 2022
@pinussilvestrus
Copy link
Contributor Author

Note: Dedicated test coverage is currently missing for the Playground. I plan to tackle this as part of the properties panel integration (cf. #291).

@pinussilvestrus pinussilvestrus mentioned this pull request Jul 26, 2022
Merged
marstamm
marstamm approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@fake-join fake-join bot merged commit 38a14a9 into develop Jul 28, 2022
@fake-join fake-join bot deleted the 280-palette-module branch July 28, 2022 09:34
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marstamm marstamm marstamm approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme

@smbea smbea Awaiting requested review from smbea

Assignees

@pinussilvestrus pinussilvestrus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide Palette as own feature module
2 participants
@pinussilvestrus @marstamm