Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add runtime implementation of document preview component #1332

Merged

Conversation

vsgoulart
Copy link
Contributor

Add runtime implementation of the document preview component and missing design fixes

Closes #1327

  • This PR adds a new form-js element or visually changes an existing component.

@vsgoulart vsgoulart requested a review from Skaiir December 12, 2024 14:58
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 12, 2024
@vsgoulart vsgoulart changed the title 1327 implement document preview runtime feat: add runtime implementation of document preview component Dec 12, 2024
@github-actions github-actions bot temporarily deployed to demo-1327-implement-document-p December 12, 2024 15:29 Destroyed
@Skaiir
Copy link
Contributor

Skaiir commented Dec 12, 2024

Something potentially to follow up on:

These error states are quite tiny and could benefit of some iconography or something.
image

@github-actions github-actions bot temporarily deployed to demo-1327-implement-document-p December 12, 2024 16:31 Destroyed
Copy link
Contributor

@Skaiir Skaiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the visuals can be polished but this delivers a bunch of value already and is plenty consistent. Code quality is good as always.

@github-actions github-actions bot temporarily deployed to demo-1327-implement-document-p December 12, 2024 20:43 Destroyed
@vsgoulart vsgoulart merged commit 8d44c8a into 1327-document-preview Dec 12, 2024
12 checks passed
@vsgoulart vsgoulart deleted the 1327-implement-document-preview-runtime branch December 12, 2024 20:55
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants