-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add runtime implementation of document preview component #1332
Merged
vsgoulart
merged 9 commits into
1327-document-preview
from
1327-implement-document-preview-runtime
Dec 12, 2024
Merged
feat: add runtime implementation of document preview component #1332
vsgoulart
merged 9 commits into
1327-document-preview
from
1327-implement-document-preview-runtime
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsgoulart
changed the title
1327 implement document preview runtime
feat: add runtime implementation of document preview component
Dec 12, 2024
github-actions
bot
temporarily deployed
to
demo-1327-implement-document-p
December 12, 2024 15:29
Destroyed
github-actions
bot
temporarily deployed
to
demo-1327-implement-document-p
December 12, 2024 16:31
Destroyed
Skaiir
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the visuals can be polished but this delivers a bunch of value already and is plenty consistent. Code quality is good as always.
github-actions
bot
temporarily deployed
to
demo-1327-implement-document-p
December 12, 2024 20:43
Destroyed
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add runtime implementation of the document preview component and missing design fixes
Closes #1327
form-js
element or visually changes an existing component.