Update lockfile preactversion to 10.15.1 and fix null default options serialization issue #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update Reason the tests failed: preactjs/preact#3354
|
@vsgoulart I changed how we do UI tests with the userEvent library (instead of sending discrete events), because preact 10.6.3 had this change which made a ton of tests fail. I haven't removed all the instances of fireEvent, mostly those which failed. But I will try to get rid of fireEvent everywhere it makes sense in a follow-up PR. |
vsgoulart
approved these changes
Sep 30, 2024
| fireEvent.focus(filterInput); | ||
| fireEvent.keyDown(filterInput, { key: 'Enter', code: 'Enter' }); | ||
| await userEvent.click(filterInput); | ||
| await userEvent.keyboard('{enter}'); |
There was a problem hiding this comment.
I think enter is capitalized, could you check if it's really working or if it doesn't make any difference?
Suggested change
| await userEvent.keyboard('{enter}'); | |
| await userEvent.keyboard('{Enter}'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1282