Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): Don't clip radio buttons #1261

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

vsgoulart
Copy link
Contributor

Related to #1140

Closes camunda/camunda#19945

  • This PR adds a new form-js element or visually changes an existing component.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 11, 2024
@vsgoulart vsgoulart force-pushed the 3688-trimmed-radio-button-2 branch 2 times, most recently from 863a4b0 to df57c9d Compare September 11, 2024 15:48
@Skaiir Skaiir self-requested a review September 11, 2024 18:26
Copy link
Contributor

@Skaiir Skaiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clipping is intentional for long labels. With this change you can totally break the structure unfortunately. And since it can be driven by variables we don't really want that. I'm not sure if it's possible to properly do clipping but also have the label wrap the checkbox in the DOM.

I think we need to split them, just generally, even if it means adding a nesting node to flexbox them.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Sep 11, 2024
@Skaiir Skaiir self-requested a review September 12, 2024 10:43
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 12, 2024
Copy link
Contributor Author

@vsgoulart vsgoulart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Skaiir There are some problems with the Carbonization, there's no padding between radio items and the checked state is not working on checkboxes or radio buttons anymore
Screenshot 2024-09-12 at 14 06 16

@Skaiir Skaiir force-pushed the 3688-trimmed-radio-button-2 branch from f1866f6 to 7272cfe Compare September 12, 2024 14:56
@Skaiir Skaiir force-pushed the 3688-trimmed-radio-button-2 branch from 7272cfe to 8411455 Compare September 12, 2024 15:13
@Skaiir Skaiir changed the base branch from develop to main September 13, 2024 08:17
@Skaiir Skaiir merged commit fde7c43 into main Sep 13, 2024
11 of 12 checks passed
@Skaiir Skaiir deleted the 3688-trimmed-radio-button-2 branch September 13, 2024 09:02
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasklist Form - Radio group rendering cut-off
3 participants