fix: dynamic list collapsing issue #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skaiir
changed the title
Skaiir
force-pushed
the
monkey-patch-dynamic-list-issue
branch
from
b9f58c0 to
aa3ad91
Compare
vsgoulart
reviewed
Aug 26, 2024
Comment on lines
78
to
91
| it('should render collapsed items under `fjs-repeat-row-collapsed`', function () { | ||
| // given | ||
| const field = { | ||
| ...defaultField, | ||
| nonCollapsedItems: 1, | ||
| }; | ||
|
|
||
| // when | ||
| const { container } = createDynamicList({ field }); | ||
|
|
||
| // then | ||
| const collapsedItems = container.querySelectorAll('.fjs-repeat-row-collapsed .fjs-form-field-textfield'); | ||
| expect(collapsedItems).to.have.length(2); | ||
| }); |
There was a problem hiding this comment.
This test is not really guaranteeing that we're outputting the correct data, the ideal test would be to just check the output data. It it possible to write a test like that?
I would just delete this test if it's not possible since this test is just testing the implementation details of the dynamic list
Skaiir
force-pushed
the
monkey-patch-dynamic-list-issue
branch
from
8826763 to
b50879f
Compare
vsgoulart
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1230