feat: add filepicker properties panel #1244
Conversation
vsgoulart
force-pushed
the
1239-properties-panel
branch
from
19b25a2 to
697c19d
Compare
| singleLine: true, | ||
| setValue, | ||
| variables, | ||
| description, |
There was a problem hiding this comment.
A regex validation would be good to have here. Especially if you plan to inject it into the HTML. I'm sure you're going to sanitize it somewhere down the line, but it may become confusing for a user if say they use a ; or something and it doesn't work without a properties panel error.
There was a problem hiding this comment.
I can add a validation here to check if it's comma separated but I believe there's not big danger since you can't execute JS in the accept property of the input
There was a problem hiding this comment.
The validation here is less about the risk and more about the UX in my view. If there is any risk to be honest it needs to be handled later anyways because of the feel variables.
| return editField(field, path, value); | ||
| }; | ||
|
|
||
| return ToggleSwitchEntry({ |
There was a problem hiding this comment.
Wouldn't it make sense to feel enable this? It might help creating more generic forms.
* feat: add filepicker properties panel * refactor: rework filepicker properties panel
* feat: add filepicker properties panel * refactor: rework filepicker properties panel
* feat: add filepicker properties panel * refactor: rework filepicker properties panel
* feat: add filepicker properties panel * refactor: rework filepicker properties panel
* feat: add filepicker properties panel * refactor: rework filepicker properties panel
Related to #1239
form-jselement or visually changes an existing component.