Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent drag and drop from accessing prop when undefined #1219

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: Prevent drag and drop from accessing prop when undefined #1219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/form-js-editor/src/features/dragging/Dragging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ export class Dragging {
let targetParentId;

if (formFieldNode) {
formField = this._formFieldRegistry.get(formFieldNode.dataset.id);
columns = (formField.layout || {}).columns;
formField = this._formFieldRegistry.get(formFieldNode.dataset.id) || { layout: {} };
columns = formField.layout.columns;
Comment on lines +81 to +82
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Skaiir this bug seems to be only happening on the Desktop modeler on Windows, I couldn't reproduce it locally but this is the issue if you follow the stack trace

Could you give it a try and reproduce it on your machine? (It should be ok to merge this anyway)


// (1) check for row constraints
if (isRow(target)) {
Expand Down
Loading