fix: prevent datetime from validating early #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've got some test coverage for this in #1124 |
douglasbouttell-camunda
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1099
The root cause issue for this is the fact that the datetime component has a lot of funky synchronization code that leads to onChange being called when it initializes. The simplest and quickest way to fix this, is to not call onChange when newValue = oldValue, and it makes sense generally.
But ideally, we wouldn't want this logic branch to be called on init at all. Now I'm not sure I can fix this without a full refactor of datetime, and this component is a house of cards so my suggestion is, we take the easy fix for now, and I've raised this issue to provide a refactor to the component in the future.