Implement JS Function / Scripting Component #1100

Skaiir · 2024-03-19T06:25:35Z

volodymyr-melnykc · 2024-03-25T13:04:41Z

@Skaiir The toggle "Do not submit" can be unclear, especially when placed before the input for function.
I suggest moving it down to be after the field for Javascript code and updating the text to:

Do not submit the function's result with the form submission

Another suggestion is to update the explanation text for function parameters:

From: "Define the parameters to pass to the javascript sandbox."
To: "Define the parameters to pass to the javascript function."

volodymyr-melnykc · 2024-03-25T13:30:00Z

@Skaiir Not directly related to the JS component but good to do.

Can we update the icons for the iFrame and Group components to the new ones in Figma? As well as reorder them: (1) Group, (2) Dynamic list, (3) iFrame?
And I can update the documentation (to reflect visual updates).

Let me know if it's better to handle as a separate issue.

vsgoulart

@Skaiir In the future it would be better to split into a PR for properties panel, one for the schema package and for the editor/viewer

packages/form-js-viewer/src/render/components/icons/JSFunction.svg

packages/form-js-editor/src/render/components/editor-form-fields/EditorJSFunctionField.js

vsgoulart · 2024-04-04T17:03:13Z

packages/form-js-viewer/src/render/components/form-fields/JSFunctionField.js

+
+  const [ sandbox, setSandbox ] = useState(null);
+  const [ hasRunLoad, setHasRunLoad ] = useState(false);
+  const [ iframeContainerId ] = useState(`fjs-sandbox-iframe-container_${uuidv4()}`);


I agree with Douglas, it looks like we don't really need this.
If it's really necessary we could try to replace it with crypto.randomUUID()

vsgoulart · 2024-04-04T17:06:41Z

packages/form-js-viewer/test/spec/render/components/form-fields/JSFunctionField.spec.js

+    });
+
+    // wait for the iframe to compute the expression and pass it back
+    await new Promise(r => setTimeout(r, 100)).then(() => {


we can use waitFor from testing library here I think

packages/form-js-viewer/src/render/components/form-fields/JSFunctionField.js

vsgoulart · 2024-04-04T17:14:45Z

packages/form-js-viewer/src/render/components/form-fields/JSFunctionField.js

+    Websandbox.connection.setLocalApi({ compute: ___executeUserCode___ });
+  `;
+
+    const _sandbox = Sandbox.create(hostAPI, {


Can't you update the sandbox instead of always creating a new one?

We actually want to completely destroy it, to make sure all user code event subscriptions get wiped as they are working on it in the playground. In the viewer this will only run once.

vsgoulart · 2024-04-04T17:15:41Z

@Skaiir We need to rebase this branch

vsgoulart · 2024-04-04T17:16:31Z

@volodymyr-melnykc do we track the use of the form components anywhere? I think we can do some really interesting things, but I don't see most users using it because it looks a bit too complex to me.

volodymyr-melnykc · 2024-04-05T11:45:23Z

@volodymyr-melnykc do we track the use of the form components anywhere? I think we can do some really interesting things, but I don't see most users using it because it looks a bit too complex to me.

@vsgoulart We implemented the event tracking here: https://github.com/camunda/team-hto/issues/350

I prepared the report about form components usage. It's available here:
https://eu.mixpanel.com/s/3256O2

Related to #1102

Related to #1103

vsgoulart

@Skaiir Just one small comment left

We have a bug on the table component, we need to validated the values to see if they're strings because this crashes the entire app

vsgoulart · 2024-04-10T09:45:18Z

packages/form-js-viewer/test/spec/render/components/form-fields/JSFunctionField.spec.js

+    });
+
+    // wait for the iframe to compute the expression and pass it back
+    await new Promise(r => setTimeout(r, 100)).then(() => {


Please also replace the other occurrences with the waitFor I mentioned in the other comments

Skaiir · 2024-05-07T17:47:09Z

Deprioritized due to the re-architecture project.

Skaiir self-assigned this Mar 19, 2024

bpmn-io-tasks bot added the in progress Currently worked on label Mar 19, 2024

Skaiir added the deploy-preview label Mar 19, 2024

github-actions bot temporarily deployed to demo-js-script-component March 19, 2024 06:27 Destroyed

github-actions bot temporarily deployed to demo-js-script-component March 19, 2024 06:46 Destroyed

Base automatically changed from 1037-hidden-fields-fix-playground-root to 1073-hidden-fields-schema March 20, 2024 09:42

Base automatically changed from 1073-hidden-fields-schema to 1073-hidden-fields-tests March 20, 2024 09:42

Base automatically changed from 1073-hidden-fields-tests to 1073-hidden-fields-impl March 20, 2024 09:43

github-actions bot temporarily deployed to demo-js-script-component March 20, 2024 11:34 Destroyed

Base automatically changed from 1073-hidden-fields-impl to develop March 20, 2024 11:36

Skaiir changed the title ~~WIP~~ WIP: script component Mar 20, 2024

Skaiir force-pushed the js-script-component branch from 166f7fc to 2bdbc10 Compare March 20, 2024 12:17

github-actions bot temporarily deployed to demo-js-script-component March 20, 2024 12:17 Destroyed

github-actions bot temporarily deployed to demo-js-script-component March 22, 2024 07:02 Destroyed

Skaiir force-pushed the js-script-component branch from 773111e to 8becf41 Compare March 25, 2024 04:46

github-actions bot temporarily deployed to demo-js-script-component March 25, 2024 04:46 Destroyed

Skaiir changed the title ~~WIP: script component~~ Implement script component Mar 25, 2024

Skaiir changed the title ~~Implement script component~~ Implement script component (WIP) Mar 25, 2024

Skaiir force-pushed the js-script-component branch from 8becf41 to e723faa Compare March 25, 2024 05:00

github-actions bot temporarily deployed to demo-js-script-component March 25, 2024 05:00 Destroyed

github-actions bot temporarily deployed to demo-js-script-component March 25, 2024 05:37 Destroyed

Skaiir force-pushed the js-script-component branch from 4535f38 to 7f8e939 Compare March 25, 2024 17:26

github-actions bot temporarily deployed to demo-js-script-component March 25, 2024 17:27 Destroyed

Skaiir force-pushed the js-script-component branch from 7f8e939 to 3e97e82 Compare March 25, 2024 17:32

github-actions bot temporarily deployed to demo-js-script-component March 25, 2024 17:32 Destroyed

Skaiir force-pushed the js-script-component branch from 3e97e82 to 27774b0 Compare April 2, 2024 06:04

github-actions bot temporarily deployed to demo-js-script-component April 2, 2024 06:04 Destroyed

Skaiir force-pushed the js-script-component branch from 27774b0 to f5d35da Compare April 2, 2024 06:57

vsgoulart reviewed Apr 4, 2024

View reviewed changes

Skaiir added 6 commits April 8, 2024 09:13

feat: implement script component (viewer)

2d797d6

Related to #1102

feat: implement script component (editor)

1065dbe

Related to #1102

chore: add advanced group to palette

05a3283

Related to #1102

feat: implement script component properties panel

5578647

Related to #1102

feat: script component schema definition

de470a3

Related to #1102

chore: script component tests

dcbe010

Related to #1102

Skaiir force-pushed the js-script-component branch from 75e7eb8 to b661452 Compare April 8, 2024 07:14

github-actions bot temporarily deployed to demo-js-script-component April 8, 2024 07:14 Destroyed

github-actions bot temporarily deployed to demo-js-script-component April 8, 2024 07:19 Destroyed

wip review comments

4f833f4

Skaiir force-pushed the js-script-component branch from 7756938 to 4f833f4 Compare April 8, 2024 07:30

github-actions bot temporarily deployed to demo-js-script-component April 8, 2024 07:30 Destroyed

Skaiir added 3 commits April 8, 2024 10:15

chore: use lodash equality in expression field

c571d95

chore: prevent unecessary script component updates

2f9cae0

Related to #1102

chore: memoized indexes in formfield to prevent unneccessary updates

f809482

Related to #1102

github-actions bot temporarily deployed to demo-js-script-component April 8, 2024 11:36 Destroyed

chore: removed uuid dependency

4345acb

Related to #1103

Skaiir force-pushed the js-script-component branch from 4a2e1d4 to 4345acb Compare April 8, 2024 11:48

github-actions bot deployed to demo-js-script-component April 8, 2024 11:49 View deployment

vsgoulart reviewed Apr 10, 2024

View reviewed changes

Skaiir marked this pull request as draft May 2, 2024 06:32

bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels May 2, 2024

Skaiir added backlog Queued in backlog and removed in progress Currently worked on labels May 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement JS Function / Scripting Component #1100

Implement JS Function / Scripting Component #1100

Skaiir commented Mar 19, 2024 •

edited

Loading

volodymyr-melnykc commented Mar 25, 2024 •

edited

Loading

volodymyr-melnykc commented Mar 25, 2024

vsgoulart left a comment

vsgoulart Apr 4, 2024

vsgoulart Apr 4, 2024

vsgoulart Apr 4, 2024

Skaiir Apr 8, 2024

vsgoulart commented Apr 4, 2024

vsgoulart commented Apr 4, 2024

volodymyr-melnykc commented Apr 5, 2024 •

edited

Loading

vsgoulart left a comment

vsgoulart Apr 10, 2024

Skaiir commented May 7, 2024

Implement JS Function / Scripting Component #1100

Are you sure you want to change the base?

Implement JS Function / Scripting Component #1100

Conversation

Skaiir commented Mar 19, 2024 • edited Loading

volodymyr-melnykc commented Mar 25, 2024 • edited Loading

volodymyr-melnykc commented Mar 25, 2024

vsgoulart left a comment

Choose a reason for hiding this comment

vsgoulart Apr 4, 2024

Choose a reason for hiding this comment

vsgoulart Apr 4, 2024

Choose a reason for hiding this comment

vsgoulart Apr 4, 2024

Choose a reason for hiding this comment

Skaiir Apr 8, 2024

Choose a reason for hiding this comment

vsgoulart commented Apr 4, 2024

vsgoulart commented Apr 4, 2024

volodymyr-melnykc commented Apr 5, 2024 • edited Loading

vsgoulart left a comment

Choose a reason for hiding this comment

vsgoulart Apr 10, 2024

Choose a reason for hiding this comment

Skaiir commented May 7, 2024

Skaiir commented Mar 19, 2024 •

edited

Loading

volodymyr-melnykc commented Mar 25, 2024 •

edited

Loading

volodymyr-melnykc commented Apr 5, 2024 •

edited

Loading