fix: properly pass this variable context to dynamic list elems
#1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,11 +79,11 @@ export class RepeatRenderManager { | |||
|
|
|||
| return ( | |||
| <> | |||
| {displayValues.map((value, index) => | |||
| {displayValues.map((itemValue, itemIndex) => | |||
| <RepetitionScaffold | |||
There was a problem hiding this comment.
(nitpick, something to keep in mind for the future)
I would have { ...restProps } at the start do that it can't override any explicitly named props in future and help avoid this issue.
React will evaluate properties in order so you can define elements like so
<SomeComponent
overridableProperty={...}
{...restProps}
nonOverridableProperty={...}
/>
douglasbouttell-camunda
approved these changes
Mar 6, 2024
vsgoulart
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1085
Issue was that restProps also had "value" passed from outer elements, but it was the value of the full dynamic list. So it was overriding the value obtained in the map. Simply changed the variable name to get around the override. Added a test scenario to ensure this never happens again.