Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure repeatRenderManager passes down props correctly #1033

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: ensure repeatRenderManager passes down props correctly #1033

merged 1 commit into from
Feb 20, 2024

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Feb 13, 2024

Related to #1029

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 13, 2024
@Skaiir Skaiir marked this pull request as ready for review February 20, 2024 06:59
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 20, 2024
@Skaiir
Copy link
Contributor Author

Skaiir commented Feb 20, 2024 •
edited
Loading

@vsgoulart could you check if this indeed fixes #1029 ? Pretty sure this is the root cause.

@Skaiir Skaiir requested a review from vsgoulart February 20, 2024 06:59
vsgoulart
vsgoulart approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@vsgoulart vsgoulart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue for me on Tasklist

@vsgoulart vsgoulart merged commit 9384369 into main Feb 20, 2024
18 checks passed
@vsgoulart vsgoulart deleted the 1029-default-rows-clearing branch February 20, 2024 15:40
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsgoulart vsgoulart vsgoulart approved these changes

Assignees

@Skaiir Skaiir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skaiir @vsgoulart