Implement HTML component and cleanup Text component #1007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #1004
github-actions
bot
temporarily deployed
to
demo-1004-html-render-componen
github-actions
bot
temporarily deployed
to
demo-642-relax-text-component-
github-actions
bot
temporarily deployed
to
demo-642-relax-text-component-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of maintaining our own sanitation code, we can just use DOMPurify. I don't really trust our own code from being purely safe from all injections, and we're also restricting people from doing a lot of stuff in their text-fields, like styling which has been requested a few times.
I've also removed our dependency on preact-markup because I found it hard to justify, at the end of the day it was just doing dangerouslySetHtml with extra steps.
Closes #642
Closes #1004