Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert defaults to named exports where possible. #918

Closed
Skaiir opened this issue Nov 28, 2023 · 2 comments
Closed

Convert defaults to named exports where possible. #918

Skaiir opened this issue Nov 28, 2023 · 2 comments
Labels
spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Nov 28, 2023

What should we do?

Move to using named exports by default.

Why should we do it?

To ensure consistent naming and reduce reassignments.
@Skaiir Skaiir added backlog Queued in backlog spring cleaning Could be cleaned up one day labels Nov 28, 2023
@Skaiir Skaiir mentioned this issue Nov 28, 2023
Merged
@pinussilvestrus
Copy link
Contributor

I have the feeling this one will be in backlog forever, as the benefits are not that high. Do you think it makes sense to keep it or rather to our well-known refactor-as-you-go strategy?

Skaiir added a commit that referenced this issue Jan 10, 2024
@Skaiir
chore(linter): add no-default-export rule
eebdef8 
Related to #918
Skaiir added a commit that referenced this issue Jan 10, 2024
@Skaiir
chore: use named exports in viewer
021683b 
Related to #918
Skaiir added a commit that referenced this issue Jan 10, 2024
@Skaiir
chore: use named exports in viewer tests
0636183 
Related to #918
@Skaiir Skaiir mentioned this issue Jan 10, 2024
Merged
Skaiir added a commit that referenced this issue Jan 10, 2024
@Skaiir
chore: use named exports in editor
e53d439 
Related to #918
Skaiir added a commit that referenced this issue Jan 10, 2024
@Skaiir
chore: use named exports in editor tests
7f7f1e3 
Related to #918
Skaiir added a commit that referenced this issue Jan 10, 2024
@Skaiir
chore: use named exports in playground source & tests
dfb0a3d 
Closes #918
This was referenced Jan 10, 2024
Merged
Merged
Skaiir added a commit that referenced this issue Jan 10, 2024
@Skaiir
chore: use named exports in playground source & tests
c851954 
Closes #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in editor
6bc584a 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in editor tests
715aa5a 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in playground source & tests
a1286b1 
Closes #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore(linter): add no-default-export rule
1a62482 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in viewer
da96493 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in viewer tests
133d04e 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in editor
99eeb29 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in editor tests
61e4fd7 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in playground source & tests
8053454 
Closes #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore(linter): add no-default-export rule
beb0253 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in viewer
3d7f445 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in viewer tests
1b5d71d 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in editor
96caa8d 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in editor tests
924a808 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in playground source & tests
485a9e1 
Closes #918
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 11, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Jan 11, 2024
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore(linter): add no-default-export rule
c5a0926 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in viewer
591a7db 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in viewer tests
ef0d7d3 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in editor
471c438 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in editor tests
d514901 
Related to #918
Skaiir added a commit that referenced this issue Jan 11, 2024
@Skaiir
chore: use named exports in playground source & tests
0f043bd 
Closes #918
@Skaiir Skaiir closed this as completed Jan 29, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 29, 2024
@Skaiir
Copy link
Contributor Author

Skaiir commented Jan 29, 2024

This is now enforced via linting rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pinussilvestrus @Skaiir