-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Implement] Create filepicker input component #1239
Comments
This was referenced Aug 19, 2024
Skaiir
added a commit
that referenced
this issue
Sep 5, 2024
Skaiir
added a commit
that referenced
this issue
Sep 5, 2024
Skaiir
added a commit
that referenced
this issue
Sep 5, 2024
Skaiir
added a commit
that referenced
this issue
Sep 5, 2024
Skaiir
added a commit
that referenced
this issue
Sep 5, 2024
Skaiir
added a commit
that referenced
this issue
Sep 5, 2024
Skaiir
added a commit
that referenced
this issue
Sep 6, 2024
vsgoulart
pushed a commit
that referenced
this issue
Sep 9, 2024
vsgoulart
added a commit
that referenced
this issue
Sep 9, 2024
* feat: implement file registry on filepicker * fix: fix file registry key * fix: delete file when dynamic list item is deleted * test: fix filepicker tests * chore: revert unnecessary change * fix: properly handle dynamic lists deletion * fix: set input file value after expanding dynamic list items * test: fix tests * fix: trim all files from a dynamic list subtree * fix: refactor form field instance registry * chore: added `useBooleanExpressionEvaluation` hook * fix: improve file picker reliability Related to #1239 * chore: changed filepicker prefix to `files::` Related to #1239 * fix: ensure the hidden filepicker gets disabled as well Related to #1239 * chore: adjust filepicker tests * chore: cleanup formFieldInstanceRegistry tests Related to #1239 * refactor: Improve typing * refactor: Improve variable naming * fix: fix dynamic list expand button label * fix: prevent collapsed dynamic list items from unmounting * refactor: Remove unnecessary method, improve types and delete files on hide if events * test: remove duplicated test * fix: clear file references to deleted files Related to #1239 --------- Co-authored-by: Skaiir <[email protected]>
vsgoulart
added a commit
that referenced
this issue
Sep 9, 2024
* feat: implement file registry on filepicker * fix: fix file registry key * fix: delete file when dynamic list item is deleted * test: fix filepicker tests * chore: revert unnecessary change * fix: properly handle dynamic lists deletion * fix: set input file value after expanding dynamic list items * test: fix tests * fix: trim all files from a dynamic list subtree * fix: refactor form field instance registry * chore: added `useBooleanExpressionEvaluation` hook * fix: improve file picker reliability Related to #1239 * chore: changed filepicker prefix to `files::` Related to #1239 * fix: ensure the hidden filepicker gets disabled as well Related to #1239 * chore: adjust filepicker tests * chore: cleanup formFieldInstanceRegistry tests Related to #1239 * refactor: Improve typing * refactor: Improve variable naming * fix: fix dynamic list expand button label * fix: prevent collapsed dynamic list items from unmounting * refactor: Remove unnecessary method, improve types and delete files on hide if events * test: remove duplicated test * fix: clear file references to deleted files Related to #1239 --------- Co-authored-by: Skaiir <[email protected]>
Closed via #1246 |
vsgoulart
added a commit
that referenced
this issue
Sep 13, 2024
* feat: implement file registry on filepicker * fix: fix file registry key * fix: delete file when dynamic list item is deleted * test: fix filepicker tests * chore: revert unnecessary change * fix: properly handle dynamic lists deletion * fix: set input file value after expanding dynamic list items * test: fix tests * fix: trim all files from a dynamic list subtree * fix: refactor form field instance registry * chore: added `useBooleanExpressionEvaluation` hook * fix: improve file picker reliability Related to #1239 * chore: changed filepicker prefix to `files::` Related to #1239 * fix: ensure the hidden filepicker gets disabled as well Related to #1239 * chore: adjust filepicker tests * chore: cleanup formFieldInstanceRegistry tests Related to #1239 * refactor: Improve typing * refactor: Improve variable naming * fix: fix dynamic list expand button label * fix: prevent collapsed dynamic list items from unmounting * refactor: Remove unnecessary method, improve types and delete files on hide if events * test: remove duplicated test * fix: clear file references to deleted files Related to #1239 --------- Co-authored-by: Skaiir <[email protected]>
vsgoulart
added a commit
that referenced
this issue
Sep 23, 2024
* feat: implement file registry on filepicker * fix: fix file registry key * fix: delete file when dynamic list item is deleted * test: fix filepicker tests * chore: revert unnecessary change * fix: properly handle dynamic lists deletion * fix: set input file value after expanding dynamic list items * test: fix tests * fix: trim all files from a dynamic list subtree * fix: refactor form field instance registry * chore: added `useBooleanExpressionEvaluation` hook * fix: improve file picker reliability Related to #1239 * chore: changed filepicker prefix to `files::` Related to #1239 * fix: ensure the hidden filepicker gets disabled as well Related to #1239 * chore: adjust filepicker tests * chore: cleanup formFieldInstanceRegistry tests Related to #1239 * refactor: Improve typing * refactor: Improve variable naming * fix: fix dynamic list expand button label * fix: prevent collapsed dynamic list items from unmounting * refactor: Remove unnecessary method, improve types and delete files on hide if events * test: remove duplicated test * fix: clear file references to deleted files Related to #1239 --------- Co-authored-by: Skaiir <[email protected]>
vsgoulart
changed the title
[Implement] Create file input component
[Implement] Create filepicker input component
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Design mocks: link
What should we do?
accept
which configures the file extensions the input can select andmultiple
which configures if the file picker can select multiple filesWhy should we do it?
The text was updated successfully, but these errors were encountered: