Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Implement] Create filepicker input component #1239

Closed
vsgoulart opened this issue Aug 18, 2024 · 1 comment · Fixed by #1264
Closed

[Implement] Create filepicker input component #1239

vsgoulart opened this issue Aug 18, 2024 · 1 comment · Fixed by #1264
Assignees

Comments

@vsgoulart
Copy link
Contributor

vsgoulart commented Aug 18, 2024

Design mocks: link

What should we do?

  • Create a new filepicker input based on the design mocks
    • This new input will be keyed
    • This new input will have 2 new configuration properties: accept which configures the file extensions the input can select and multiple which configures if the file picker can select multiple files
    • The file values should not be included in the data on the form submit event because files can be too big. Instead we will create a separate file store which costumers users can consume on a case by case basis. The file key will be provided on the submit even data instead of the file values.

Why should we do it?

  • Managing documents is a common use case when dealing with forms
  • So we can add document handling to the Camunda 8 ecosystem
@vsgoulart vsgoulart self-assigned this Aug 18, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Aug 18, 2024
Skaiir added a commit that referenced this issue Sep 5, 2024
Skaiir added a commit that referenced this issue Sep 5, 2024
Skaiir added a commit that referenced this issue Sep 5, 2024
Skaiir added a commit that referenced this issue Sep 5, 2024
Skaiir added a commit that referenced this issue Sep 5, 2024
Skaiir added a commit that referenced this issue Sep 5, 2024
Skaiir added a commit that referenced this issue Sep 5, 2024
Skaiir added a commit that referenced this issue Sep 6, 2024
vsgoulart pushed a commit that referenced this issue Sep 9, 2024
vsgoulart added a commit that referenced this issue Sep 9, 2024
* feat: implement file registry on filepicker

* fix: fix file registry key

* fix: delete file when dynamic list item is deleted

* test: fix filepicker tests

* chore: revert unnecessary change

* fix: properly handle dynamic lists deletion

* fix: set input file value after expanding dynamic list items

* test: fix tests

* fix: trim all files from a dynamic list subtree

* fix: refactor form field instance registry

* chore: added `useBooleanExpressionEvaluation` hook

* fix: improve file picker reliability

Related to #1239

* chore: changed filepicker prefix to `files::`

Related to #1239

* fix: ensure the hidden filepicker gets disabled as well

Related to #1239

* chore: adjust filepicker tests

* chore: cleanup formFieldInstanceRegistry tests

Related to #1239

* refactor: Improve typing

* refactor: Improve variable naming

* fix: fix dynamic list expand button label

* fix: prevent collapsed dynamic list items from unmounting

* refactor: Remove unnecessary method, improve types and delete files on hide if events

* test: remove duplicated test

* fix: clear file references to deleted files

Related to #1239

---------

Co-authored-by: Skaiir <[email protected]>
vsgoulart added a commit that referenced this issue Sep 9, 2024
* feat: implement file registry on filepicker

* fix: fix file registry key

* fix: delete file when dynamic list item is deleted

* test: fix filepicker tests

* chore: revert unnecessary change

* fix: properly handle dynamic lists deletion

* fix: set input file value after expanding dynamic list items

* test: fix tests

* fix: trim all files from a dynamic list subtree

* fix: refactor form field instance registry

* chore: added `useBooleanExpressionEvaluation` hook

* fix: improve file picker reliability

Related to #1239

* chore: changed filepicker prefix to `files::`

Related to #1239

* fix: ensure the hidden filepicker gets disabled as well

Related to #1239

* chore: adjust filepicker tests

* chore: cleanup formFieldInstanceRegistry tests

Related to #1239

* refactor: Improve typing

* refactor: Improve variable naming

* fix: fix dynamic list expand button label

* fix: prevent collapsed dynamic list items from unmounting

* refactor: Remove unnecessary method, improve types and delete files on hide if events

* test: remove duplicated test

* fix: clear file references to deleted files

Related to #1239

---------

Co-authored-by: Skaiir <[email protected]>
@Skaiir
Copy link
Contributor

Skaiir commented Sep 10, 2024

Closed via #1246

@Skaiir Skaiir closed this as completed Sep 10, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Sep 10, 2024
vsgoulart added a commit that referenced this issue Sep 13, 2024
* feat: implement file registry on filepicker

* fix: fix file registry key

* fix: delete file when dynamic list item is deleted

* test: fix filepicker tests

* chore: revert unnecessary change

* fix: properly handle dynamic lists deletion

* fix: set input file value after expanding dynamic list items

* test: fix tests

* fix: trim all files from a dynamic list subtree

* fix: refactor form field instance registry

* chore: added `useBooleanExpressionEvaluation` hook

* fix: improve file picker reliability

Related to #1239

* chore: changed filepicker prefix to `files::`

Related to #1239

* fix: ensure the hidden filepicker gets disabled as well

Related to #1239

* chore: adjust filepicker tests

* chore: cleanup formFieldInstanceRegistry tests

Related to #1239

* refactor: Improve typing

* refactor: Improve variable naming

* fix: fix dynamic list expand button label

* fix: prevent collapsed dynamic list items from unmounting

* refactor: Remove unnecessary method, improve types and delete files on hide if events

* test: remove duplicated test

* fix: clear file references to deleted files

Related to #1239

---------

Co-authored-by: Skaiir <[email protected]>
vsgoulart added a commit that referenced this issue Sep 23, 2024
* feat: implement file registry on filepicker

* fix: fix file registry key

* fix: delete file when dynamic list item is deleted

* test: fix filepicker tests

* chore: revert unnecessary change

* fix: properly handle dynamic lists deletion

* fix: set input file value after expanding dynamic list items

* test: fix tests

* fix: trim all files from a dynamic list subtree

* fix: refactor form field instance registry

* chore: added `useBooleanExpressionEvaluation` hook

* fix: improve file picker reliability

Related to #1239

* chore: changed filepicker prefix to `files::`

Related to #1239

* fix: ensure the hidden filepicker gets disabled as well

Related to #1239

* chore: adjust filepicker tests

* chore: cleanup formFieldInstanceRegistry tests

Related to #1239

* refactor: Improve typing

* refactor: Improve variable naming

* fix: fix dynamic list expand button label

* fix: prevent collapsed dynamic list items from unmounting

* refactor: Remove unnecessary method, improve types and delete files on hide if events

* test: remove duplicated test

* fix: clear file references to deleted files

Related to #1239

---------

Co-authored-by: Skaiir <[email protected]>
@vsgoulart vsgoulart changed the title [Implement] Create file input component [Implement] Create filepicker input component Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants