Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-resize of textarea should happen on visual text changes, not on debounce triggers #1011

Closed
Skaiir opened this issue Jan 28, 2024 · 1 comment
Closed

Auto-resize of textarea should happen on visual text changes, not on debounce triggers #1011

Skaiir opened this issue Jan 28, 2024 · 1 comment
Assignees
@Skaiir
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Jan 28, 2024 •
edited
Loading

Describe the Bug

Auto-resizing of textareas is debounced, which leads to delayed looking autosizing.

Steps to Reproduce

  1. create a new textarea
  2. in the viewer, in the textarea, spam some text, enter, some more text, enter
  3. the resizing is delayed

Expected Behavior

  1. the resizing should happen whenever a new line is created
@Skaiir Skaiir added bug Something isn't working backlog Queued in backlog spring cleaning Could be cleaned up one day labels Jan 28, 2024
@Skaiir Skaiir changed the title Auto-resize of textarea should happen on visual text changes, not on regular changes Auto-resize of textarea should happen on visual text changes, not on debounce triggers Jan 28, 2024
Skaiir added a commit that referenced this issue Jan 31, 2024
@Skaiir
fix: resize textarea on input changes instead of value changes
60a6154 
Closes #1011
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jan 31, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Jan 31, 2024
Skaiir added a commit that referenced this issue Jan 31, 2024
@Skaiir
fix: resize textarea on input changes
fb7009f 
Closes #1011
@Skaiir Skaiir mentioned this issue Jan 31, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 31, 2024
Skaiir added a commit that referenced this issue Jan 31, 2024
@Skaiir
fix: resize textarea on input changes
0e59ec1 
Closes #1011
vsgoulart pushed a commit that referenced this issue Jan 31, 2024
@Skaiir
fix: resize textarea on input changes (#1017)
5985a3d 
Closes #1011
vsgoulart added a commit that referenced this issue Jan 31, 2024
@Skaiir @renovate
@bpmn-io-bot @douglasbouttell-camunda @vsgoulart @nikku
merge dev to master (prep for 1.7) (#1018)
83b0fe5 
* chore: update actions/setup-node digest to d86ebcd (#967)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(markdown): add margins to all markdown elements (#986)

* fix: improve image editor placeholder styles

Related to #994

* chore: adjust iframe placeholder font size

Related to #994

* feat: add `security` properties for iFrame

Closes #901

* feat: add warning step to iframe security attributes config

Related to #901

* fix: show iframe title in the editor

Closes #990

* chore(CHANGELOG): correct minor formatting issues (#1003)

* chore: update actions/cache action to v4 (#995)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update actions/upload-artifact digest to 26f96df (#979)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: repeatable entry parameters now validate with errors

Closes #966

* feat: implement number field debouncing

Closes #958

* chore: remove superfluous useEffects

Related to #958

* fix: Prevent demo data from being created on edited tables

Closes #997

* chore: Add experimental tag

Related to #997

* chore: update actions/upload-artifact digest to d00351b (#1014)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: implement HTML display component

Closes #1004

* feat(schema): support HTML component

Related to #1004

* chore: remove our dependency on preact-markup

Related to #1004

* fix: limit cm-editor properties height to 400px

Related to #1004

* chore: cleanup html and text components

Related to #1004

* fix: handle native CSS scoping & added tests

#1004

* chore: updated snapshots

* chore: Update deps (#1008)

* chore: Update deps

* chore: Revert properties panel update

* chore: update dependency source-map-loader to v5 (#988)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: replace dependency npm-run-all with npm-run-all2 ^5.0.0 (#1012)

* chore: replace dependency npm-run-all with npm-run-all2 ^5.0.0

* chore: Update to 6.1.1

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Vinicius Goulart <[email protected]>

* fix: resize textarea on input changes (#1017)

Closes #1011

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: bpmn-io-bot <[email protected]>
Co-authored-by: Douglas Bouttell <[email protected]>
Co-authored-by: Vinicius Goulart <[email protected]>
Co-authored-by: Niklas Kiefer <[email protected]>
Co-authored-by: Nico Rehwaldt <[email protected]>
Co-authored-by: Skaiir <[email protected]>
Skaiir added a commit that referenced this issue Jan 31, 2024
@Skaiir
fix: resize textarea on input changes (#1017)
286c17f 
Closes #1011
Skaiir added a commit that referenced this issue Jan 31, 2024
@Skaiir
fix: resize textarea on input changes (#1017)
edea2e0 
Closes #1011
Skaiir added a commit that referenced this issue Jan 31, 2024
@Skaiir
fix: resize textarea on input changes
f8374be 
Closes #1011
@Skaiir Skaiir mentioned this issue Jan 31, 2024
Merged
Skaiir added a commit that referenced this issue Jan 31, 2024
@Skaiir
fix: resize textarea on input changes
9a61a6b 
Closes #1011
vsgoulart pushed a commit that referenced this issue Feb 1, 2024
@Skaiir @vsgoulart
fix: resize textarea on input changes
0ff522b 
Closes #1011
@vsgoulart vsgoulart mentioned this issue Feb 1, 2024
Merged
@Skaiir
Copy link
Contributor Author

Skaiir commented Feb 5, 2024

Closed via #1022

@Skaiir Skaiir closed this as completed Feb 5, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 5, 2024
@nikku nikku mentioned this issue Feb 5, 2024
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Skaiir