Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom component example #7

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Oct 10, 2023

Closes #6

This adds an example for custom form components. It follows the pattern of existing examples in the bpmn-io sphere, e.g. https://github.com/bpmn-io/bpmn-js-examples/tree/main/properties-panel-extension.

@pinussilvestrus
Copy link
Contributor Author

bpmn-io/form-js#776 was merged, waiting for the release to open this up for review.

@pinussilvestrus pinussilvestrus force-pushed the 6-custom-form-field-example branch from a0910c0 to be35ca6 Compare November 1, 2023 13:06
@pinussilvestrus pinussilvestrus marked this pull request as ready for review November 1, 2023 13:07
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 1, 2023
@pinussilvestrus
Copy link
Contributor Author

As form-js 1.4.0 is released, this is ready for review now.

@pinussilvestrus
Copy link
Contributor Author

@vsgoulart @Skaiir The blog post that references this example is about to be released: bpmn-io/bpmn.io#171

Let's try to get this merged, I think we are fine with the webpack setup 👍

@pinussilvestrus
Copy link
Contributor Author

Merging it now as the blog post is out, and the code snippets shown where approved over there. We can improve the example whenever we want.

@pinussilvestrus pinussilvestrus merged commit 6b15215 into master Nov 7, 2023
1 check passed
@pinussilvestrus pinussilvestrus deleted the 6-custom-form-field-example branch November 7, 2023 13:35
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example for custom form elements
1 participant