fix(context-pad): do not re-open for targets that were removed #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
May 7, 2024
| }); | ||
| }); | ||
|
|
||
| change(elements); |
There was a problem hiding this comment.
Do we have this behavior covered in ChangeSupport specs?
I'd be afraid that we otherwise mock something that we don't even guarantee.
There was a problem hiding this comment.
elements.changed is always fired even when an element was deleted (using a command). GraphicsFactory then updates all parents. Since deleted elements don't have parents anymore they're ignored. shape.changed and connection.changed aren't fired when elements are deleted.
There was a problem hiding this comment.
We did handle delete explicitly in the context pad previously but changed it when the multi-element context pad was introduced.
There was a problem hiding this comment.
Great explaination, thanks a lot. 🏅
nikku
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that
elements.changedcould feature elements that were removed wasn't previously taken into account.