Be able to type diagram and events #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested review from
philippfromme,
a team and
barmac
and removed request for
a team
Consumers of the diagram may bootstrap it with a service map that is being used during type inference.
* handles combined override / optional args signatures
vsgoulart
reviewed
Feb 26, 2024
|
I will have a look at this today. |
barmac
approved these changes
Feb 29, 2024
1 task
nikku
added a commit
to bpmn-io/bpmn-js
that referenced
this pull request
Apr 29, 2024
This PR builds on upon diagram-js provided service and event typing: * bpmn-io/diagram-js#862 It allows you to specify (public) types exposed by your BPMN toolkit trough a ServiceMap. Events exposed are parsed from the EventBus dynamic types. Closes #2121
nikku
added a commit
to bpmn-io/bpmn-js
that referenced
this pull request
Apr 29, 2024
This PR builds on upon diagram-js provided service and event typing: * bpmn-io/diagram-js#862 It allows you to specify (public) types exposed by your BPMN toolkit trough a ServiceMap. Events exposed are parsed from the EventBus dynamic types. Closes #2121
nikku
added a commit
to bpmn-io/bpmn-js
that referenced
this pull request
Apr 29, 2024
This PR builds on upon diagram-js provided service and event typing: * bpmn-io/diagram-js#862 It allows you to specify (public) types exposed by your BPMN toolkit trough a ServiceMap. Events exposed are parsed from the EventBus dynamic types. Closes #2121
nikku
added a commit
to bpmn-io/bpmn-js
that referenced
this pull request
Apr 30, 2024
This PR builds on upon diagram-js provided service and event typing: * bpmn-io/diagram-js#862 It allows you to specify (public) types exposed by your BPMN toolkit trough a ServiceMap. Events exposed are parsed from the EventBus dynamic types. Closes #2121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows implementors to type the diagram (available services) and eventBus events (available events):
Sublime Text
VSCode