Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Seata Saga designer as an external project #852

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

ptyin
Copy link
Contributor

@ptyin ptyin commented Jan 23, 2024

Hi, @nikku

Thanks for your great work. Apache Seata (Incubator) is a distributed transaction framework. And recently, we have used diagram-js as the backbone to refactor our new version of Saga Designer (a visual tool to orchestrate Saga pattern transaction).

This PR aims to provide an external link in the README.

@ptyin ptyin closed this Jan 27, 2024
@ptyin ptyin deleted the patch-1 branch January 27, 2024 13:57
@nikku
Copy link
Member

nikku commented Jan 28, 2024

@ptyin Nice to see you're using diagram-js to visualize things. Any particular reason you closed the PR again?

@ptyin
Copy link
Contributor Author

ptyin commented Feb 1, 2024

@ptyin Nice to see you're using diagram-js to visualize things. Any particular reason you closed the PR again?

Waiting for feedback for a week made me aware that it might be considered impolite to submit a pull request without prior discussion or issue. In this case, what are your thoughts on the idea of adding it?

@nikku
Copy link
Member

nikku commented Feb 1, 2024

We're happy to add this if it is a good showcase for our libraries. Consider re-opening.

We're candid, too. So if we feel like a contribution needs prior discussion we're going to voice it.

@ptyin ptyin restored the patch-1 branch February 1, 2024 11:48
@ptyin ptyin reopened this Feb 1, 2024
@nikku nikku merged commit d3d08c2 into bpmn-io:develop Feb 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants