Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AutoPlaceUtil Types #844

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Fix AutoPlaceUtil Types #844

merged 5 commits into from
Jan 16, 2024

Conversation

philippfromme
Copy link
Contributor

Closes #843

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 16, 2024
nikku
nikku reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. We could consider to add some type test cases for the utilities.

@philippfromme
Copy link
Contributor Author

I did actually add a test to fix this bug but then I removed it because usually we only have dedicated spec.ts files for the core features. 🤔

@nikku
Copy link
Member

nikku commented Jan 16, 2024

You can keep it, as long as it does not increase bundle size 🙈

@philippfromme
Copy link
Contributor Author

@nikku Done. ✅

@philippfromme philippfromme requested a review from nikku January 16, 2024 14:23
@nikku nikku merged commit 7eaa995 into develop Jan 16, 2024
12 checks passed
@nikku nikku deleted the auto-place-types branch January 16, 2024 14:43
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 16, 2024
@nikku
Copy link
Member

nikku commented Jan 16, 2024

Great stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku Awaiting requested review from nikku

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getNextPosition ts type bug in AutoPlaceUtil.d.ts
2 participants
@philippfromme @nikku