fix(search): guard against whitespace only pattern

bpmn-io · Nov 21, 2024 · e80568c · e80568c
1 parent bf03eb3
commit e80568c
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/features/search/search.js b/lib/features/search/search.js
@@ -36,6 +36,12 @@ export default function search(items, pattern, options) {
     keys
   } = options;
 
+  pattern = pattern.trim().toLowerCase();
+
+  if (!pattern) {
+    throw new Error('<pattern> must not be empty');
+  }
+
   const words = pattern.trim().toLowerCase().split(/\s+/);
 
   return items.flatMap((item) => {

diff --git a/test/spec/features/search/searchSpec.js b/test/spec/features/search/searchSpec.js
@@ -475,6 +475,22 @@ describe('features/search', function() {
     expect(results).to.have.length(1);
   }));
 
+
+  it('should error on whitespace pattern', inject(function(search) {
+
+    // given
+    const fn = () => {
+      search([], ' ', {
+        keys: [
+          'title'
+        ]
+      });
+    };
+
+    // then
+    expect(fn).to.throw(/<pattern> must not be empty/);
+  }));
+
 });