fix(outline): prevent access of non-existing connection bounds

Closes #822
bpmn-io · Nov 7, 2023 · 790fc34 · 790fc34
1 parent 88c11a4
commit 790fc34
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 14 deletions.
diff --git a/lib/features/outline/Outline.js b/lib/features/outline/Outline.js
@@ -46,15 +46,20 @@ export default function Outline(eventBus, styles) {
 
   var self = this;
 
-  function createOutline(gfx, element) {
+  /**
+   * @param {SVGElement} gfx
+   *
+   * @return {SVGElement} outline
+   */
+  function createOutline(gfx) {
     var outline = svgCreate('rect');
 
     svgAttr(outline, assign({
-      x: - self.offset,
-      y: - self.offset,
+      x: 0,
+      y: 0,
       rx: 4,
-      width: element.width + self.offset * 2,
-      height: element.height + self.offset * 2
+      width: 100,
+      height: 100
     }, OUTLINE_STYLE));
 
     return outline;
@@ -69,12 +74,11 @@ export default function Outline(eventBus, styles) {
     var outline = domQuery('.djs-outline', gfx);
 
     if (!outline) {
-      outline = self.getOutline(element) || createOutline(gfx, element);
+      outline = self.getOutline(element) || createOutline(gfx);
       svgAppend(gfx, outline);
-
-    } else {
-      self.updateShapeOutline(outline, element);
     }
+
+    self.updateShapeOutline(outline, element);
   });
 
   eventBus.on([ 'connection.added', 'connection.changed' ], function(event) {
@@ -84,7 +88,7 @@ export default function Outline(eventBus, styles) {
     var outline = domQuery('.djs-outline', gfx);
 
     if (!outline) {
-      outline = createOutline(gfx, element);
+      outline = createOutline(gfx);
       svgAppend(gfx, outline);
     }
 
@@ -128,7 +132,7 @@ Outline.prototype.updateShapeOutline = function(outline, element) {
  *
  * @param {SVGElement} outline
  * @param {Element} connection
- **/
+ */
 Outline.prototype.updateConnectionOutline = function(outline, connection) {
   var bbox = getBBox(connection);
 

diff --git a/test/spec/features/outline/OutlineSpec.js b/test/spec/features/outline/OutlineSpec.js
@@ -11,7 +11,8 @@ import {
 
 import {
   classes as svgClasses,
-  create as svgCreate
+  create as svgCreate,
+  attr as svgAttr
 } from 'tiny-svg';
 
 
@@ -47,7 +48,11 @@ describe('features/outline/Outline', function() {
       var outline = domQuery('.djs-outline', gfx);
 
       expect(outline).to.exist;
-      expect(svgClasses(gfx).has('selected')).to.be.true; // Outline class is set
+
+      expect(svgAttr(outline, 'x')).to.exist;
+
+      // outline class is set
+      expect(svgClasses(gfx).has('selected')).to.be.true;
     }));
 
 
@@ -64,7 +69,11 @@ describe('features/outline/Outline', function() {
       var outline = domQuery('.djs-outline', gfx);
 
       expect(outline).to.exist;
-      expect(svgClasses(gfx).has('selected')).to.be.true; // Outline class is set
+
+      expect(svgAttr(outline, 'x')).to.exist;
+
+      // outline class is set
+      expect(svgClasses(gfx).has('selected')).to.be.true;
     }));
 
   });
@@ -107,6 +116,11 @@ describe('features/outline/Outline', function() {
           return svgCreate('rect');
         }
       }
+
+      updateOutline(element, gfx) {
+
+        // noop
+      }
     }
 
     it('should register provider', inject(function(outline) {