fix: remove incorrect attribute in popup menu item

Related camunda/camunda-modeler#4383
bpmn-io · Jun 21, 2024 · 774daa5 · 774daa5
1 parent 1ed8694
commit 774daa5
Show file tree

Hide file tree

Showing 4 changed files with 52 additions and 1 deletion.
diff --git a/lib/features/popup-menu/PopupMenuItem.js b/lib/features/popup-menu/PopupMenuItem.js
@@ -40,7 +40,6 @@ export default function PopupMenuItem(props) {
       onMouseEnter=${ onMouseEnter }
       onMouseLeave=${ onMouseLeave }
       onDragStart=${ (event) => onAction(event, entry, 'dragstart') }
-      aria-role="button"
       draggable=${ true }
     >
       <div class="djs-popup-entry-content">

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -53,6 +53,7 @@
   ],
   "devDependencies": {
     "@babel/core": "^7.23.9",
+    "@bpmn-io/a11y": "^0.1.0",
     "@testing-library/preact": "^3.2.3",
     "babel-loader": "^9.1.3",
     "babel-plugin-istanbul": "^6.1.1",

diff --git a/test/spec/features/popup-menu/PopupMenuComponentSpec.js b/test/spec/features/popup-menu/PopupMenuComponentSpec.js
@@ -1,3 +1,5 @@
+import { expectToBeAccessible } from '@bpmn-io/a11y';
+
 import PopupMenuComponent from 'lib/features/popup-menu/PopupMenuComponent';
 
 import {
@@ -713,6 +715,16 @@ describe('features/popup-menu - <PopupMenu>', function() {
       // then
       expect(searchInput.getAttribute('aria-label')).to.eql('Search');
     });
+
+
+    it('should report no violations', async function() {
+
+      // given
+      await createPopupMenu({ container, entries, title: 'Search', search: true });
+
+      // then
+      await expectToBeAccessible(container);
+    });
   });