feat: keep selection but hide during selecting

bpmn-io · Jan 29, 2024 · 571551f · 571551f
1 parent 92d60dc
commit 571551f
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/assets/diagram-js.css b/assets/diagram-js.css
@@ -191,6 +191,12 @@ svg.new-parent {
   pointer-events: none;
 }
 
+.djs-lasso-selection .djs-outline,
+.djs-lasso-selection .djs-selection-outline,
+.djs-lasso-selection .djs-context-pad {
+  display: none !important;
+}
+
 /**
  * Resize styles
  */

diff --git a/lib/features/lasso-tool/LassoTool.js b/lib/features/lasso-tool/LassoTool.js
@@ -27,6 +27,8 @@ import {
 
 var LASSO_TOOL_CURSOR = 'crosshair';
 
+var LASSO_TOOL_SELECTING_CLS = 'djs-lasso-selection';
+
 /**
  * @param {EventBus} eventBus
  * @param {Canvas} canvas
@@ -130,6 +132,8 @@ export default function LassoTool(
 
     context.bbox = toBBox(event);
     visuals.create(context);
+
+    canvas.addMarker(canvas.getRootElement(), LASSO_TOOL_SELECTING_CLS);
   });
 
   eventBus.on('lasso.move', function(event) {
@@ -145,6 +149,8 @@ export default function LassoTool(
     var context = event.context;
 
     visuals.remove(context);
+
+    canvas.removeMarker(canvas.getRootElement(), LASSO_TOOL_SELECTING_CLS);
   });
 
 

diff --git a/test/spec/features/lasso-tool/LassoToolSpec.js b/test/spec/features/lasso-tool/LassoToolSpec.js
@@ -178,7 +178,18 @@ describe('features/lasso-tool', function() {
       dragging.move(canvasEvent({ x: 200, y: 300 }));
 
       // then
-      expect(canvas._svg.querySelector('.djs-lasso-overlay')).to.exist;
+      expect(canvas.getContainer().querySelector('.djs-lasso-overlay')).to.exist;
+    }));
+
+
+    it('should indicate selecting', inject(function(lassoTool, canvas, dragging) {
+
+      // when
+      lassoTool.activateLasso(canvasEvent({ x: 100, y: 100 }));
+      dragging.move(canvasEvent({ x: 200, y: 300 }));
+
+      // then
+      expect(canvas.getContainer().querySelector('.djs-lasso-selection')).to.exist;
     }));
 
   });