fix(popup-menu): do not filter on whitespace only input

bpmn-io · Nov 21, 2024 · 0f24e54 · 0f24e54
1 parent 5a2fd31
commit 0f24e54
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/features/popup-menu/PopupMenuComponent.js b/lib/features/popup-menu/PopupMenuComponent.js
@@ -79,7 +79,7 @@ export default function PopupMenuComponent(props) {
       return originalEntries;
     }
 
-    if (!value) {
+    if (!value.trim()) {
       return originalEntries.filter(({ rank = 0 }) => rank >= 0);
     }
 

diff --git a/test/spec/features/popup-menu/PopupMenuSpec.js b/test/spec/features/popup-menu/PopupMenuSpec.js
@@ -1531,6 +1531,25 @@ describe('features/popup-menu', function() {
     }));
 
 
+    it('should handle whitespace only search', inject(async function(popupMenu) {
+
+      // given
+      popupMenu.registerProvider('test-menu', testMenuProvider);
+      popupMenu.open({}, 'test-menu', { x: 100, y: 100 }, { search: true });
+
+      // when
+      await triggerSearch('   ');
+
+      // then
+      await waitFor(() => {
+        const shownEntries = queryPopupAll('.entry');
+
+        // just ignores it
+        expect(shownEntries).to.have.length(5);
+      });
+    }));
+
+
     describe('ranking', function() {
 
       it('should hide rank < 0 items', inject(async function(popupMenu) {