feat(create-append-anything): add create shortcut

Trigger create with 'n' and 'a' if no selection Closes #1814
bpmn-io · Jan 24, 2023 · 72fec1a · 72fec1a
1 parent 4e162ac
commit 72fec1a
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 2 deletions.
diff --git a/lib/features/create-append-anything/CreateAppendEditorActions.js b/lib/features/create-append-anything/CreateAppendEditorActions.js
@@ -24,6 +24,7 @@ CreateAppendEditorActions.prototype.registerActions = function() {
   var editorActions = this._injector.get('editorActions', false);
   var selection = this._injector.get('selection', false);
   var contextPad = this._injector.get('contextPad', false);
+  var palette = this._injector.get('palette', false);
 
   const actions = {};
 
@@ -36,6 +37,15 @@ CreateAppendEditorActions.prototype.registerActions = function() {
     );
   }
 
+  // create
+  if (palette) {
+    assign(actions, {
+      'createElement': function(event) {
+        palette.triggerEntry('create', 'click', event);
+      } }
+    );
+  }
+
   editorActions && editorActions.register(actions);
 
 };
diff --git a/lib/features/create-append-anything/CreateAppendKeyboardBindings.js b/lib/features/create-append-anything/CreateAppendKeyboardBindings.js
@@ -13,6 +13,7 @@ export default function CreateAppendKeyboardBindings(injector) {
   this._injector = injector;
   this._keyboard = this._injector.get('keyboard', false);
   this._editorActions = this._injector.get('editorActions', false);
+  this._selection = this._injector.get('selection', false);
 
   if (this._keyboard) {
     this._injector.invoke(KeyboardBindings, this);
@@ -36,6 +37,7 @@ CreateAppendKeyboardBindings.prototype.registerBindings = function() {
 
   var keyboard = this._keyboard;
   var editorActions = this._editorActions;
+  var selection = this._selection;
 
   // inherit default bindings
   KeyboardBindings.prototype.registerBindings.call(this, keyboard, editorActions);
@@ -54,7 +56,7 @@ CreateAppendKeyboardBindings.prototype.registerBindings = function() {
     }
   }
 
-  // activate append element
+  // activate append/create element
   // A
   addListener('appendElement', function(context) {
 
@@ -65,7 +67,28 @@ CreateAppendKeyboardBindings.prototype.registerBindings = function() {
     }
 
     if (keyboard && keyboard.isKey([ 'a', 'A' ], event)) {
-      editorActions && editorActions.trigger('appendElement', event);
+
+      if (selection && selection.get().length == 1) {
+        editorActions && editorActions.trigger('appendElement', event);
+      } else {
+        editorActions && editorActions.trigger('createElement', event);
+      }
+
+      return true;
+    }
+  });
+
+  // N
+  addListener('createElement', function(context) {
+
+    var event = context.keyEvent;
+
+    if (keyboard && keyboard.hasModifier(event)) {
+      return;
+    }
+
+    if (keyboard && keyboard.isKey([ 'n', 'N' ], event)) {
+      editorActions && editorActions.trigger('createElement', event);
 
       return true;
     }

diff --git a/test/spec/ModelerSpec.js b/test/spec/ModelerSpec.js
@@ -265,6 +265,7 @@ describe('Modeler', function() {
       // given
       var expectedActions = [
         'appendElement',
+        'createElement',
         'undo',
         'redo',
         'copy',