chore: remove touch interaction

Related to bpmn-io/diagram-js#796
bpmn-io · Jan 16, 2024 · 672ea11 · 672ea11
1 parent eabe834
commit 672ea11
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 63 deletions.
diff --git a/lib/Modeler.js b/lib/Modeler.js
@@ -7,7 +7,6 @@ import NavigatedViewer from './NavigatedViewer';
 
 import KeyboardMoveModule from 'diagram-js/lib/navigation/keyboard-move';
 import MoveCanvasModule from 'diagram-js/lib/navigation/movecanvas';
-import TouchModule from 'diagram-js/lib/navigation/touch';
 import ZoomScrollModule from 'diagram-js/lib/navigation/zoomscroll';
 
 import AlignElementsModule from './features/align-elements';
@@ -156,7 +155,6 @@ Modeler.prototype._interactionModules = [
   // non-modeling components
   KeyboardMoveModule,
   MoveCanvasModule,
-  TouchModule,
   ZoomScrollModule
 ];
 

diff --git a/lib/features/label-editing/LabelEditingProvider.js b/lib/features/label-editing/LabelEditingProvider.js
@@ -116,20 +116,7 @@ export default function LabelEditingProvider(
 
     var context = event.context,
         element = context.shape,
-        canExecute = event.context.canExecute,
-        isTouch = event.isTouch;
-
-    // TODO(nikku): we need to find a way to support the
-    // direct editing on mobile devices; right now this will
-    // break for desworkflowediting on mobile devices
-    // as it breaks the user interaction workflow
-
-    // TODO(nikku): we should temporarily focus the edited element
-    // here and release the focused viewport after the direct edit
-    // operation is finished
-    if (isTouch) {
-      return;
-    }
+        canExecute = event.context.canExecute;
 
     if (!canExecute) {
       return;

diff --git a/test/integration/CustomElementsSpec.js b/test/integration/CustomElementsSpec.js
@@ -12,9 +12,8 @@ import {
 
 import customElementsModules from './custom-elements';
 
-var noTouchInteractionModule = { touchInteractionEvents: [ 'value', null ] },
-    modelerModules = Modeler.prototype._modules,
-    customModules = [ customElementsModules, noTouchInteractionModule ];
+var modelerModules = Modeler.prototype._modules,
+    customModules = [ customElementsModules ];
 
 var testModules = [].concat(modelerModules, customModules);
 

diff --git a/test/spec/features/label-editing/TouchIntegrationSpec.js b/test/spec/features/label-editing/TouchIntegrationSpec.js
diff --git a/test/spec/features/modeling/behavior/DropOnFlowBehaviorSpec.js b/test/spec/features/modeling/behavior/DropOnFlowBehaviorSpec.js
@@ -11,8 +11,6 @@ import coreModule from 'lib/core';
 import moveModule from 'diagram-js/lib/features/move';
 import modelingModule from 'lib/features/modeling';
 
-var noTouchInteractionModule = { touchInteractionEvents: [ 'value', null ] };
-
 import {
   createCanvasEvent as canvasEvent
 } from '../../../../util/MockEvents';
@@ -26,7 +24,6 @@ describe('modeling/behavior - drop on connection', function() {
 
   beforeEach(bootstrapModeler(diagramXML, {
     modules: [
-      noTouchInteractionModule,
       moveModule,
       modelingModule,
       coreModule