Enhance query performance using batch-loading #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylipp
force-pushed
the
enhance-query-performance
branch
from
50813df
to
cebb695
Compare
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
==========================================
+ Coverage 71.28% 71.39% +0.11%
==========================================
Files 285 285
Lines 7246 7274 +28
Branches 1531 1519 -12
==========================================
+ Hits 5165 5193 +28
Misses 2046 2046
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Accessing `box.location.base_id` previously issued another DB select query to fetch the location field albeit already joining with the location table. Now the `Box.select()` call is updated
- reduce duplicated code - sort classes in file
…egories Would be fixed by updating the RBP names in the Auth0 scripts for dev and staging; but that in turn after merging confusingly breaks all open PRs as long as they are not rebased on master yet Cf. https://trello.com/c/J34Z923v
pylipp
force-pushed
the
enhance-query-performance
branch
from
50696a9
to
d3e10c1
Compare
HaGuesto
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make more use of batch-loading for user, base, and organisation fields, hence avoiding excessive DB queries.