Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle gitTagPrefix in preparePromotions method #99

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Properly handle gitTagPrefix in preparePromotions method #99

merged 1 commit into from
Dec 4, 2023

Conversation

matthewdevenny
Copy link
Member

@matthewdevenny matthewdevenny commented Nov 20, 2023 •
edited
Loading

preparePromotions was not passing along the gitTagPrefix if it was set to the gitRepo.getCommitsBetween method

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2023 •
edited
Loading

✅ Deploy Preview for dockhand-jenkins ready!

Name Link
🔨 Latest commit 59352b2
🔍 Latest deploy log https://app.netlify.com/sites/dockhand-jenkins/deploys/655b6e2b730ce00008c8b510
😎 Deploy Preview https://deploy-preview-99--dockhand-jenkins.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewdevenny matthewdevenny merged commit 4054e5d into master Dec 4, 2023
7 checks passed
@matthewdevenny matthewdevenny deleted the bugfix/prepare-promotions-tag-prefix branch December 4, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanjennings jordanjennings jordanjennings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewdevenny @jordanjennings