refactor: change method name

bowphp · Dec 13, 2024 · 04edbf8 · 04edbf8
1 parent 5ba2a2f
commit 04edbf8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/src/Storage/Service/FTPService.php b/src/Storage/Service/FTPService.php
@@ -111,7 +111,7 @@ public function connect()
         $this->connection = $connection;
 
         $this->login();
-        $this->setConnectionRoot();
+        $this->changePath();
         $this->setConnectionPassiveMode();
     }
 
@@ -165,21 +165,18 @@ private function login(): bool
     }
 
     /**
-     * Set the connection root.
+     * Change path.
      *
      * @param string $path
      * @return void
      */
-    public function setConnectionRoot(string $path = '')
+    public function changePath(?string $path = null)
     {
         $base_path = $path ?: $this->config['root'];
 
         if ($base_path && (!@ftp_chdir($this->connection, $base_path))) {
             throw new RuntimeException('Root is invalid or does not exist: ' . $base_path);
         }
-
-        // Store absolute path for further reference.
-        ftp_pwd($this->connection);
     }
 
     /**
@@ -359,13 +356,13 @@ public function makeDirectory(string $dirname, int $mode = 0777): bool
 
         foreach ($directories as $directory) {
             if (false === $this->makeActualDirectory($directory)) {
-                $this->setConnectionRoot();
+                $this->changePath();
                 return false;
             }
             ftp_chdir($connection, $directory);
         }
 
-        $this->setConnectionRoot();
+        $this->changePath();
 
         return true;
     }
@@ -567,7 +564,7 @@ protected function listDirectoryContents($directory = '.')
 
         $listing = @ftp_rawlist($this->getConnection(), '.') ?: [];
 
-        $this->setConnectionRoot();
+        $this->changePath();
 
         return  $this->normalizeDirectoryListing($listing);
     }

diff --git a/tests/Filesystem/FTPServiceTest.php b/tests/Filesystem/FTPServiceTest.php
@@ -27,7 +27,7 @@ protected function setUp(): void
 
     protected function tearDown(): void
     {
-        $this->ftp_service->setConnectionRoot();
+        $this->ftp_service->changePath();
     }
 
     public function test_the_connection()