Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using freeqdsk to read geqdsk files #25

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

ZedThree
Copy link
Member

@ZedThree ZedThree commented Dec 7, 2023

No description provided.

Copy link
Collaborator

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of new dependencies, I doubt that freeqdsk is packaged for fedora, so updating zoidberg will require packaging that as well, and its dependency fortranformat.

So I am wondering - what are the advantages of freeqdsk?

@ZedThree
Copy link
Member Author

freeqdsk is becoming the community standard package for reading geqdsk files, and I'm pushing to remove custom implementations in favour of a single, maintained package.

It also has more features than other implementations, including aeqdsk and peqdsk formats, support for COCOS numbers != 1, some customisation of the header format.

Copy link
Collaborator

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like worthy goals 👍
The dependency tree seems manageable.
Only question is whether there are enough tokamak users that justify to set this as a hard dependency.
We could maybe also add an extra tokamak = freeqdsk section to options.extras_require?

@ZedThree ZedThree merged commit a90a107 into master Jan 18, 2024
11 checks passed
@ZedThree ZedThree deleted the use-freeqdsk branch January 18, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants