Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stuff of thermal monitoring what decrases overall system perfo… #6

Open
wants to merge 1 commit into
base: cm-14.1
Choose a base branch
from

Conversation

LuizPauloDamaceno
Copy link

…rmance

This will unlock the maximum of system can delivery for performance (can be applied to another variants too without problems) and preserve the hardware monitoring to prevent overheating. This fix to brightness bug too, putting more higher limits and sample rate of monitoring to LCD_LED_MONITOR (Original is LCD SKIN MANAGEMENT).

…rmance

This will unlock the maximum of system can delivery for performance (can be applied to another variants too without problems) and preserve the hardware monitoring to prevent overheating. This fix to brightness bug too, putting more higher limits and sample rate of monitoring to LCD_LED_MONITOR (Original is LCD SKIN MANAGEMENT).
@Dinokin
Copy link

Dinokin commented Feb 10, 2017

you should be aware that the maximum rated operating temperature for the battery is 45°C. if you increase the maximum temperature for the CPU you will kill your battery eventually.

@danielstuart14
Copy link
Contributor

danielstuart14 commented Feb 10, 2017

I can't understand why we'd change the thermal-config to something that isn't what the SOC was design for.

If we want this device to be supported by Lineage, we'd stop modding things that shouldn't be modded

@danielstuart14
Copy link
Contributor

danielstuart14 commented Feb 10, 2017

Also, changing [LCD_SKIN_MANAGEMENT] to anything else that isn't this, is the same as removing its entry.

Thermal-engine searches for this entry, if it can't find, it'll just rollback to default. Here:
https://github.com/AQSD/android_vendor_lenovo_A6020/commit/8d82982d086cac74c67ff42033f2b913abc1be56

And even with this commit, we still need to revert the mess that was done on sensor hal.
https://github.com/AQSD/android_device_lenovo_A6020/commit/8af25b968081e68335b8ec25499ff2f453e37041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants