Add an optional redirect(cache=sec) argument #1370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument sets an optional Cache-Control header for redirects. Allows for more fined-grained control over browser caching for known short- and long- lived redirects.
avelino
requested changes
May 24, 2022
| """ Aborts execution and causes a 303 or 302 redirect, depending on | ||
| the HTTP protocol version. """ | ||
| if not code: | ||
| code = 303 if request.get('SERVER_PROTOCOL') == "HTTP/1.1" else 302 | ||
| res = response.copy(cls=HTTPResponse) | ||
| res.status = code | ||
| if type(cache) is int: |
There was a problem hiding this comment.
You can check if the variable exists, you don't need to look at its type.
If it is an unexpected string it will be the developer's responsibility
avelino
added
Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument sets an optional
Cache-Controlheader for redirects. Allows for more fined-grained control over client and browser caching for known short- and long-lived redirects. The argument accepts an integer value with the number of seconds to add to themax-agedirective. Browser support: universal.